Fix/macos m2 detection bug #19369
Merged
Fix/macos m2 detection bug #19369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree
|
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
@cwall-dev Thank you for the contribution. I added some generated output needed by our integration system. Could you share test results for x64 / ARM64? (Ideally, we'd have an integration test for this, but currently we target a x64 macos agent) |
merlynomsft
approved these changes
Jan 24, 2024
|
@merlynomsft I successfully ran the existing unit tests on a Macbook Air M2 2022. I also copied the build output to the current version (2.232.0) on my local agent on the same Macbook and then ran a build successfully. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: UseDotNetV2
Description: Fixed os architecture detection for Apple M1/2
Documentation changes required: N
Added unit tests: N
Attached related issue: #19174
Checklist: