Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlAzureDacpacDeploymentV1 - Support for SQL Server #19648

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

emdempster
Copy link

Task name: SqlAzureDacpacDeploymentV1

Description: Added support for SQL Server deployments (on-premises or in another cloud). Azure Subscription is no longer required, as the code only uses the field for telemetry. It is still optional. Additionally, Windows authentication has been added to support SQL Server deployments.

Documentation changes required: Y

Added unit tests: Y

Attached related issue: Y - #19636

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@emdempster emdempster requested review from manolerazvan and a team as code owners March 17, 2024 01:23
@v-mohithgc
Copy link
Contributor

/azp run

Copy link

Azure Pipelines failed to run 3 pipeline(s).

@emdempster
Copy link
Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 19648 in repo microsoft/azure-pipelines-tasks

@v-mohithgc
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@emdempster
Copy link
Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 19648 in repo microsoft/azure-pipelines-tasks

@ErikEJ
Copy link

ErikEJ commented Mar 27, 2024

@emdempster Looks like the task versions were not bumped

@ErikEJ
Copy link

ErikEJ commented Mar 27, 2024

I have claimed patch 7 - assuming this is in before my future PR 😄

@emdempster
Copy link
Author

@ErikEJ thanks for the head's up. The version has been bumped. There's been a lot of other activity in this task in the past couple weeks.

@emdempster
Copy link
Author

@v-mohithgc or @manolerazvan, could I get pipelines kicked off for this PR one more time? Apologies for asking, but as a non-employee, I'm not sure how to get the checks going.

@v-mohithgc
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@emdempster
Copy link
Author

@v-mohithgc, is there anything I need to finish this PR? Or is it ready to move forward with a merge?

@emdempster
Copy link
Author

@manolerazvan and @microsoft/release-management-task-team, could I get an approval on this change? @dzsquared has previously approved the change to include Windows Authentication for SQL Server support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants