Fail the build when the user's script fails #351
Conversation
|
Hi @robrich, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
| @@ -20,5 +20,8 @@ Write-Host "ScriptPath= $ScriptPath" | |||
| $scriptCommand = "& `"$ScriptPath`" $scriptArguments" | |||
| Write-Host "scriptCommand= $scriptCommand" | |||
| Invoke-Expression -Command $scriptCommand | |||
| if ($LASTEXITCODE -ne 0) { | |||
| Write-Error -Message "##[error]BUILD FAILED: $LASTEXITCODE" | |||
There was a problem hiding this comment.
you don't need the ##[error] here we have overridden the Write-Error so it should take care of the formatting for you for the log highlighting.
There was a problem hiding this comment.
I agree. Should we even include "BUILD FAILED"?
|
Muthu, can you work with Eric. This has been rewritten and we just can't take it like it is. It will break previous behavior. We have to add an input to influence behavior and the default would be the previous behavior. I believe this is irrelevant since it has been rewritten since. |
|
Closing this PR as this change is no more relevant |
No description provided.