Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix live tests issue #177

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Fix live tests issue #177

merged 3 commits into from
Oct 28, 2021

Conversation

guenp
Copy link
Contributor

@guenp guenp commented Oct 26, 2021

This PR fixes an issue found on the end to end tests repo. Currently, common.py is used with a relative import, but this causes an issue when the tests are copied and run in our end to end tests (see tests.live/Run.ps1).

Changes:

  • Drop relative imports to common.py test module and add it to the path for aio tests
  • Copy over conftest.py file to live tests folder
  • Add conftests.py file to aio folder that adds common.py to path

@guenp guenp requested a review from vxfield October 26, 2021 23:17
@guenp guenp merged commit 463db2f into main Oct 28, 2021
@guenp guenp deleted the guenp/fix-live-tests-rel-import branch October 28, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants