Introduce the "shots" parameter to 'sumbit' function of the 'Target' object #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurKamalov
force-pushed
the
arturk/add_shots_param_to_target_submit
branch
from
dfb54f9
to
4341bb7
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
azure-quantum/tests/unit/recordings/test_job_submit_quantinuum_with_none_shots.yaml
Fixed
Show fixed
Hide fixed
azure-quantum/tests/unit/recordings/test_job_submit_rigetti_typed_input_params_with_shots.yaml
Dismissed
Show dismissed
Hide dismissed
azure-quantum/tests/unit/recordings/test_job_submit_rigetti_dict_input_params_with_shots.yaml
Dismissed
Show dismissed
Hide dismissed
azure-quantum/tests/unit/recordings/test_job_submit_quantinuum_with_shots.yaml
Fixed
Show fixed
Hide fixed
azure-quantum/tests/unit/recordings/test_job_submit_quantinuum_with_deprecated_num_shots.yaml
Fixed
Show fixed
Hide fixed
ArthurKamalov
force-pushed
the
arturk/add_shots_param_to_target_submit
branch
from
4341bb7
to
98856c8
Compare
azure-quantum/tests/unit/recordings/test_job_submit_quantinuum_with_none_shots.yaml
Dismissed
Show dismissed
Hide dismissed
azure-quantum/tests/unit/recordings/test_job_submit_quantinuum_with_shots.yaml
Dismissed
Show dismissed
Hide dismissed
azure-quantum/tests/unit/recordings/test_job_submit_quantinuum_with_deprecated_num_shots.yaml
Dismissed
Show dismissed
Hide dismissed
kikomiss
reviewed
Jan 3, 2024
ArthurKamalov
force-pushed
the
arturk/add_shots_param_to_target_submit
branch
from
232d002
to
8e394e8
Compare
kikomiss
reviewed
Jan 5, 2024
kikomiss
reviewed
Jan 5, 2024
kikomiss
changed the base branch from
main
to
users/kikomiss/features/qiskit-cirq-init-with-workspace-and-qsharp-lang
added 3 commits
January 9, 2024 12:50
* The num_shots option for a target class now is checked by a helper function. * New warning is printed on passing shots and num_shots together. * Small fixes.
ArthurKamalov
commented
Jan 9, 2024
ArthurKamalov
commented
Jan 9, 2024
There was a problem hiding this comment.
@kikomiss , Note: The Quantinuum backend will not print deprecation message for passing the 'count' option because its own parameter name for shots is also count, so we should not prevent user from specifying it, as any other "Quntinuum-specific" option.
ArthurKamalov
commented
Jan 9, 2024
ArthurKamalov
commented
Jan 9, 2024
* Fix pascal target * add tests.
ArthurKamalov
commented
Jan 9, 2024
|
|
||
| def test_job_submit_pasqal_dict_input_params(self) -> None: | ||
| num_runs = 150 | ||
| result = self._run_job(TEST_PULSER, input_params={"count": num_runs}) |
There was a problem hiding this comment.
@kikomiss, t it seems that Pascal targets now expect count option instead of runs (At least on prod).
kikomiss
reviewed
Jan 9, 2024
kikomiss
reviewed
Jan 10, 2024
| @@ -53,7 +55,10 @@ def __init__( | |||
|
|
|||
| @classmethod | |||
| def _default_options(cls): | |||
| return Options(count=500, targetCapability="BasicExecution") | |||
| other_options = { | |||
| cls._SHOTS_PARAM_NAME: 500 | |||
There was a problem hiding this comment.
we've been setting the default options through _DEFAULT_SHOTS_COUNT earlier, we should probably follow the same pattern here.
There was a problem hiding this comment.
Yeah, I just thought it may be ok to keep it as literal since it is currently used only in one place, but I guess it wouldn't hurt🙂
kikomiss
reviewed
Jan 10, 2024
ArthurKamalov
commented
Jan 10, 2024
| if isinstance(input_params, InputParams): | ||
| typed_input_params = input_params | ||
| input_params = { | ||
| "runs": typed_input_params.runs, | ||
| self.__class__._SHOTS_PARAM_NAME: typed_input_params.runs, |
There was a problem hiding this comment.
It seems so. As I noted here #542 (comment), provider does not respond on runs option anymore, and when job is submitted, it falls back to Pascal's default values and returns "count" in details of a result job.
* small fixes.
…-and-qsharp-lang' into arturk/add_shots_param_to_target_submit
kikomiss
approved these changes
Jan 10, 2024
ArthurKamalov
merged commit 761eb39
into
users/kikomiss/features/qiskit-cirq-init-with-workspace-and-qsharp-lang
2 checks passed
kikomiss
added a commit
that referenced
this pull request
Jan 10, 2024
…object (#542) * Introduce the "shots" parameter to 'sumbit' function of the 'Target' object * Remove num_shots from kwargs. * Add warning on passing shots for estimator * Add 'shots' option for qiskit backends. * Refactor target shots option * The num_shots option for a target class now is checked by a helper function. * New warning is printed on passing shots and num_shots together. * Allow provider-specific shots options. * Fix pascal target * add tests. * Add back all possible shots params --------- Co-authored-by: ArturKamalov <v-akamalov@microsoft.com> Co-authored-by: kikomiss <144282031+kikomiss@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces new parameter
shortfor a number of repeats forTarget.submitfunction.Things to do:
x-client-cpu: x64field is removed in the new test recordings.