Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abbreviation of Log Analytics Workspace deviates from recommendation #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ var sqlName = nameModule[4].outputs.shortName
var planName = nameModule[5].outputs.shortName
var uamiName = nameModule[6].outputs.shortName
var dplscrName = nameModule[7].outputs.shortName
var lawName = nameModule[8].outputs.shortName
var logName = nameModule[8].outputs.shortName

var deploymentNameStructure = '${workloadName}-${environment}-${sequenceFormatted}-{rtype}-${deploymentTime}'

Expand Down Expand Up @@ -181,7 +181,7 @@ var resourceTypes = [
'plan'
'uami'
'dplscr'
'law'
'log'
]

@batchSize(1)
Expand Down Expand Up @@ -241,7 +241,7 @@ module monitoring './modules/monitoring/main.bicep' = {
params: {
resourceGroupName: replace(rgNamingStructure, '{rgName}', 'monitoring')
appInsightsName: 'appInsights-${webAppName}'
logAnalyticsWorkspaceName: lawName
logAnalyticsWorkspaceName: logName
logAnalyticsWorkspaceSku: 'PerGB2018'
retentionInDays: 30
location: location
Expand Down
4 changes: 2 additions & 2 deletions modules/common/createValidAzResourceName.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ param location string
'appi' // Application Insights
'uami' // User-assigned Managed Identity
'dplscr' // Deployment Script
'law' // Log Analytics Workspace
'log' // Log Analytics Workspace
])
param resourceType string
param environment string
Expand Down Expand Up @@ -112,7 +112,7 @@ var Defs = {
maxLength: 63 // Guess, not documented
alwaysRemoveSegmentSeparator: false
}
law: {
log: {
lowerCase: false
maxLength: 63
alwaysRemoveSegmentSeparator: false
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion modules/monitoring/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ resource resourceGroup 'Microsoft.Resources/resourceGroups@2022-09-01' = {
tags: mergeTags
}

module logAnalyticsWorkspace 'law.bicep' = {
module logAnalyticsWorkspace 'log.bicep' = {
name: take(replace(deploymentNameStructure, '{rtype}', 'log'), 64)
scope: resourceGroup
params: {
Expand Down