This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Adding Checkin and hooking it up to the viewlet #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It doesn't currently change anything. Something is not set up properly for this to work.
- assert.throws doesn't seem to work as expected with Async/Await
- also cleaned up some unused error strings - also fixed the status update to only run one at a time.
|
Hi @jpricketMSFT, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
jeffyoung
suggested changes
Feb 10, 2017
src/tfvc/repository.ts
Outdated
| @@ -50,6 +51,12 @@ export class Repository { | |||
| return this._repositoryRootFolder; | |||
| } | |||
|
|
|||
| public async Checkin(files: string[], comment: string, workItemIds: number[]): Promise<string> { | |||
| Logger.LogDebug(`TFVC Repository.Undo`); | |||
src/tfvc/tfvc-extension.ts
Outdated
| } | ||
|
|
||
| try { | ||
| this._manager.Telemetry.SendEvent(TfvcTelemetryEvents.Checkin); |
src/tfvc/tfvcerror.ts
Outdated
| @@ -63,24 +81,25 @@ export class TfvcError { | |||
|
|
|||
| export class TfvcErrorCodes { | |||
| public static get MissingArgument(): string { return "MissingArgument"; } | |||
| public static get BadConfigFile(): string { return "BadConfigFile"; } | |||
| //public static get BadConfigFile(): string { return "BadConfigFile"; } | |||
There was a problem hiding this comment.
Remove the commented out ones.
jeffyoung
approved these changes
Feb 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added commit box hover provider but this doesn't get used in the current Insiders build.
Added Checkin command and tests
Hooked up checkin to the viewlet