This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Initial tf.exe framework #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpricket
reviewed
Feb 22, 2017
| @@ -86,6 +87,9 @@ export class FindWorkspace implements ITfvcCommand<IWorkspace> { | |||
| } | |||
| } | |||
| } | |||
| if (mappings.length === 0) { | |||
| throw new Error("Could not find a workspace with mappings. Perhaps the wrong version of TF is being used with the selected folder?"); | |||
jpricket
reviewed
Feb 22, 2017
src/tfvc/commands/getversion.ts
Outdated
| return this.GetOptions(); | ||
| } | ||
|
|
||
| public async ParseExeOutput(executionResult: IExecutionResult): Promise<string> { |
There was a problem hiding this comment.
it might be could to refactor this eventually. Not now. Can we add a TODO?
jpricket
reviewed
Feb 22, 2017
src/tfvc/commands/status.ts
Outdated
| } | ||
|
|
||
| public async ParseExeOutput(executionResult: IExecutionResult): Promise<IPendingChange[]> { | ||
| return this.ParseOutput(executionResult); |
There was a problem hiding this comment.
Need a TODO here since you already have the Arguments changed.
jpricket
reviewed
Feb 22, 2017
src/tfvc/tfvc.ts
Outdated
| if (!stats || !stats.isFile()) { | ||
| Logger.LogWarning(`TFVC ${this._tfvcPath} exists but isn't a file.`); | ||
| throw new TfvcError({ | ||
| message: Strings.TfMissingError + this._tfvcPath, | ||
| tfvcErrorCode: TfvcErrorCodes.TfvcNotFound | ||
| }); | ||
| } | ||
| this._isExe = path.extname(this._tfvcPath) === ".exe"; | ||
| if (this._isExe) { | ||
| this._minVersion = "14.102.25619.0"; //Minimum tf.exe version |
There was a problem hiding this comment.
Can we leave this at 14.102.0?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.