This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Disable functionalithy when no team project is found #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the project is TFVC and we can't determine the team project, don't display the team project, build and work items status bar items (don't even initalize them). Instead, set a message that the functionality is explicitly disabled. #178
| if (this.EnsureInitialized(RepositoryType.ANY)) { | ||
| // Update the extensions | ||
| this._teamExtension.InitializeStatusBars(); | ||
| //this._tfvcExtension.InitializeStatusBars(); |
There was a problem hiding this comment.
Remove this commented line?
There was a problem hiding this comment.
Sorry, didn't see your comment (nor did I expect you to review on Saturday night). 😄 We leave some comments in like this so we can easily find the place where we might need to do something in the future. In this case, if the TFVC extension would ever provide status bar items, this is where we'd do it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the project is TFVC and we can't determine the team project, don't display the team project, build and work items status bar items (don't even initalize them). Instead, set a message that the functionality is explicitly disabled. #178