Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Package file updates (updates for 'Associate Work Items' menu option) #267

Merged
merged 2 commits into from
Jun 27, 2017

Conversation

jeffyoung
Copy link
Contributor

Should address #262.

Today, the 'Associate Work Items' menu item shows for all SCM providers (Hg, Perforce, TFVC and Git). For Git, it shows even if it is not a VSTS/TFS hosted repository. It is rendered for Git repositories like so:
image
This PR changes the order so that it now appears like this:
image
(I think it makes the UI better in keeping the Git commands grouped together.)
The TFVC option remains unchanged:
image
And this is how it looks for Perforce (the 'Associate Work Items' menu is missing):
image

Note that I could not use an OR in a "when clause" due to it being a missing feature. Therefore, I added two commands... one specifically for Git and the other specifically for TFVC.

Finally, for Git repositories that are not hosted on VSTS/TFS, I default to showing this message:
image

Copy link
Member

@jpricket jpricket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffyoung jeffyoung merged commit 3532e65 into master Jun 27, 2017
@jeffyoung jeffyoung deleted the jeyou/package-file-updates branch June 27, 2017 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants