Updated FindWorkspace to get mappings #71
Conversation
It also parses out the team project name from the first mapping
|
Hi @jpricketMSFT, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| import { TfvcError } from "../../../src/tfvc/tfvcerror"; | ||
| import { IExecutionResult, IWorkspace } from "../../../src/tfvc/interfaces"; | ||
|
|
||
| var chai = require("chai"); |
There was a problem hiding this comment.
Either before or after going in, we should make the same change as in my last PR (import chai).
| var assert = chai.assert; | ||
| chai.should(); | ||
|
|
||
| describe("FindWorkspaceCommand", function() { |
There was a problem hiding this comment.
Perhaps we should have a prefix like "Tfvc-" on the describe so we can immediately see that it's a part of that extension?
| @@ -16,7 +16,18 @@ export class TfvcError { | |||
| tfvcErrorCode: string; | |||
| tfvcCommand: string; | |||
|
|
|||
| public constructor(data: ITfvcErrorData) { | |||
| public constructor(data: ITfvcErrorData | string) { | |||
| if (typeof data === "string") { | |||
There was a problem hiding this comment.
I'm confused... why allow typeof "string" in the constructor if it's an error?
There was a problem hiding this comment.
I wanted a quick way of creating a "missing argument exception". I agree it is confusing. I will create a static method instead.
It also parses out the team project name from the first mapping