Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing activedirectory starter? #131

Closed
snicoll opened this issue Aug 28, 2017 · 0 comments
Closed

Missing activedirectory starter? #131

snicoll opened this issue Aug 28, 2017 · 0 comments
Assignees

Comments

@snicoll
Copy link
Contributor

snicoll commented Aug 28, 2017

There is no starter for the active directory integration. That's fine if you don't but currently the autoconfigure module brings a bunch of dependencies so it isn't an autoconfigure module anymore.

  1. Either that's the dependency that one is supposed to add when they want to get started with active directory and in that case I'd recommend to rename that to starter to clarify the intend
  2. Either another starter or that dependency + required dependencies should be added. I'd argue that ordering dependencies by scope makes it clearer. Right now this module brings automatically spring-web, spring-security, jackson, powermock (I guess it's missing a test scope!). The sample brings more dependencies and it isn't clear what's optional and what's required IMO
eddumelendez added a commit to eddumelendez/azure-spring-boot-starters that referenced this issue Aug 29, 2017
Lack of scope in some dependencies. This commit adds test scope where is
required and mark other dependencies as optional.

See microsoftgh-131
@ZhijunZhao ZhijunZhao self-assigned this Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants