Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

put all autoconfigure code into one module #177

Merged
merged 8 commits into from Sep 20, 2017
Merged

put all autoconfigure code into one module #177

merged 8 commits into from Sep 20, 2017

Conversation

yungez
Copy link
Contributor

@yungez yungez commented Sep 19, 2017

  1. put all autoconfigure code into one module: aad, documentdb, microsoft graph, storage, service bus, media service
  2. delete spring data documentdb code, use dependency to spring-data-cosmosdb-documentdb
  3. remove documentdb emulator setup in appveyor
  4. update dependency of related starters who contains autoconfigure only

@msftclas
Copy link

@yungez,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@ZhijunZhao
Copy link
Contributor

ZhijunZhao commented Sep 19, 2017

A few suggestions as below:

  1. Create a starters folder and put all starters inside. At least, folder path like storage/azure-storage-spring-boot-starter should be changed to azure-storage-spring-boot-starter

  2. remove the common folder and move the parent and config out.

@yungez
Copy link
Contributor Author

yungez commented Sep 20, 2017

@ZhijunZhao, all good points. Can we make it in next PR? this one is already too hugh. :)

Copy link
Contributor

@ZhijunZhao ZhijunZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me make a few more changes in my next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants