Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions/issues during walkthrough #30

Closed
lastcoolnameleft opened this issue Jun 3, 2020 · 2 comments
Closed

Suggestions/issues during walkthrough #30

lastcoolnameleft opened this issue Jun 3, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@lastcoolnameleft
Copy link

https://github.com/likamrat/azure_arc/blob/master/azure_arc_k8s_jumpstart/docs/onboard_k8s.md

Issues:

  • When creating RG: only specific Locations work
Connected cluster resource creation is supported only in the following locations: eastus, westeurope, eastus2euap. Use the --location flag to specify one of these locations.

Recommendations:

  • az ad sp create-for-rbac generates string with quotes in it which can cause script to fail. Might be worth noting. I thought it used to generate a GUID for the password.
  • Don’t use separate script for install. Makes assumptions about OS, packager (e.g. Linux, snap)
    • Recommend listing prereqs instead like you did for Provider
@lastcoolnameleft lastcoolnameleft added the bug Something isn't working label Jun 3, 2020
@likamrat
Copy link
Contributor

likamrat commented Jun 4, 2020

Fixed. @lastcoolnameleft can you please review?
likamrat@73608cc

@likamrat likamrat self-assigned this Jun 4, 2020
@lastcoolnameleft
Copy link
Author

LGTM!

sebassem added a commit that referenced this issue Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants