Skip to content

Commit

Permalink
Fix scan hits (#16788)
Browse files Browse the repository at this point in the history
  • Loading branch information
Charles-Gagnon authored and alanrenmsft committed Aug 17, 2021
1 parent 1660718 commit 12c4f03
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
4 changes: 4 additions & 0 deletions .config/CredScanSuppressions.json
Expand Up @@ -16,6 +16,10 @@
{
"file": ".devcontainer\\devcontainer.json",
"_justification": "Local development environment - not used in production"
},
{
"file": "extensions\\asde-deployment\\notebooks\\edge\\deploy-sql-edge-remote.ipynb",
"_justification": "Deployment Notebook - usernames/passwords are entered by user"
}
]
}
1 change: 1 addition & 0 deletions extensions/cms/src/cmsUtils.ts
Expand Up @@ -32,6 +32,7 @@ export class CmsUtils {
private _cmsService: mssql.ICmsService;
private _registeredCmsServers: ICmsResourceNodeInfo[] = [];

// [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Used for unit testing, not actual valid credential")]
public async savePassword(username: string, password: string): Promise<boolean> {
let provider = await this.credentialProvider();
let result = await provider.saveCredential(username, password);
Expand Down
Expand Up @@ -26,7 +26,7 @@ suite('ConnectionStore', () => {
serverName: 'namedServer',
databaseName: 'bcd',
authenticationType: 'SqlLogin',
userName: 'cde',
userName: 'cde', // [SuppressMessage("Microsoft.Security", "CS001:SecretInline", Justification="Mock value, never actually used to connect")]
password: generateUuid(),
savePassword: true,
groupId: '',
Expand Down

0 comments on commit 12c4f03

Please sign in to comment.