Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Azure Active Directory Authentication #13

Closed
orofino opened this issue Nov 15, 2017 · 58 comments
Closed

Feature Request: Azure Active Directory Authentication #13

orofino opened this issue Nov 15, 2017 · 58 comments
Assignees
@MattIrv
Labels
Area - Connection Enhancement Request for new features or functionality
Milestone
January Release

Comments

@orofino
Copy link

orofino commented Nov 15, 2017

  • SQL Operations Studio Version: 0.23.6

Steps to Reproduce:

  1. Create new connection
  2. Select Authentication Type
@kevcunnane
Copy link
Contributor

To clarify: is this request for Azure Active Directory (integrated and password) authentication? @saurabh500 can help comment on this if so.

@orofino
Copy link
Author

orofino commented Nov 15, 2017

@kevcunnane yes, correct.

@Code-DJ
Copy link

Code-DJ commented Nov 15, 2017 •
edited
Loading

@kevcunnane since this is Azure related do you want me to move my comments to a separate issue? Thanks!

EDIT: Deleted my previous comments to keep this issue clean and moved it to a separate issue.

@saurabh500
Copy link

@orofino @Code-DJ the Azure Integrated auth support needs to get into .Net Core for the tools to use it. There is an open issue at https://github.com/dotnet/corefx/issues/8807 and we are trying to work with security team to support FedAuth on .Net Core
Are you looking for Azure Active Directory username and password support or Azure Active Directory Integrated Authentication support?

@orofino
Copy link
Author

orofino commented Nov 15, 2017 •
edited
Loading

@saurabh500 I'm looking for username/password support.

We have an Azure SQL Database with Azure AD security groups governing access. It would be great to allow users in those groups to use this application without having to create local SQL accounts.

To clarify further: I'm running MacOS 10.12

@kevcunnane
Copy link
Contributor

@Code-DJ yes, please create a separate issue for Windows authentication issues. Again that's mostly going to be upstream (e.g. improve error messages in the SqlClient driver, improve the drivers reliability) but will let us track it cleanly.

@mmoizk
Copy link

mmoizk commented Nov 15, 2017

I didn't see any voting button , so please consider my comment here as my request and vote for this feature. SSMS 17 does it great.

@orofino
Copy link
Author

orofino commented Nov 15, 2017

@mmoizk you may want to thumbs up the linked issue (dotnet/corefx#8807) as it seems the team there is referencing those for prioritization.

@sebcruz
Copy link

sebcruz commented Nov 16, 2017

Please consider my comment as an Up Vote for this. Please add the same AAD authentication options as are currently available in SSMS.

@Code-DJ
Copy link

Code-DJ commented Nov 16, 2017

Should the title be changed to Azure Active Directory Authentication for clarity?

@kevcunnane kevcunnane changed the title Feature Request: Active Directory Authentication Feature Request: Azure Active Directory Authentication Nov 16, 2017
@kevcunnane
Copy link
Contributor

@Code-DJ done.

This was referenced Nov 21, 2017
Closed
Closed
@kburtram kburtram added this to the SQL Ops GA milestone Nov 30, 2017
@Ocanamat
Copy link

Great tool guys. Please also consider this comment as my up vote for this feature request. Thanks!

@pmooij
Copy link

pmooij commented Feb 14, 2018 •
edited
Loading

Azure AD MFA, yes please! Thanks

@CoreyCaldwell
Copy link

And another vote for AD MFA

@acds
Copy link

acds commented Mar 29, 2018

+1

@kburtram kburtram modified the milestones: May "Build" Release, Backlog Apr 13, 2018
@kburtram kburtram mentioned this issue Apr 13, 2018
Closed
@Svengalx
Copy link

Svengalx commented May 8, 2018

+1

@ajilius
Copy link

ajilius commented May 11, 2018

There's been great work delivering management widgets for SQLOps, but a pity customers with mature authentication environments can't use them! Please deliver AAD authentication as a priority.

@B4PJS
Copy link

B4PJS commented May 17, 2018

Need MFA authentication

@wilsonge wilsonge mentioned this issue May 29, 2018
Closed
@kevinvngo
Copy link

+1

@kburtram kburtram mentioned this issue Oct 24, 2018
Closed
@schalkje
Copy link

schalkje commented Nov 2, 2018

+1 for MFA

@anbudhanush
Copy link

hi guys,
when this feature is expected to be released ?

@PaulStirpe
Copy link

The tools is not really useful without Active Directory Integrated Authentication and better yet Active Directory Universal Authentication with MFA. Looking forward to this feature being implemented.

@MattIrv
Copy link
Contributor

MattIrv commented Nov 2, 2018

@anbudhanush we don't have an exact date yet but we're actively working on it now

@kevcunnane kevcunnane mentioned this issue Nov 5, 2018
Closed
This was referenced Nov 6, 2018
Merged
Merged
@kevcunnane kevcunnane mentioned this issue Nov 7, 2018
Closed
@yellowianox73
Copy link

Yay! MFA

@thanksforthepen
Copy link

To clarify: is this request for Azure Active Directory (integrated and password) authentication? @saurabh500 can help comment on this if so.

11/19/2018 - Did this ever happen? I'd love to have people login with their AAD username and password.

@yualan
Copy link
Contributor

yualan commented Nov 20, 2018

Keep an eye out for the next monthly release. When we have an insider build out, feel free to try it out and let us know if there are any gaps with the feature.

@yualan
Copy link
Contributor

yualan commented Nov 28, 2018

image

Thanks to @MattIrv and @kburtram, AAD is now in the latest Insider build (1.3.4). Please try it out here and give us feedback before we include it in the December stable release: https://github.com/Microsoft/azuredatastudio/releases

@yellowianox73
Copy link

yellowianox73 commented Nov 28, 2018 via email

@yualan
Copy link
Contributor

yualan commented Nov 28, 2018

@yellowianox73 Yes, the Windows installer link works for me and confirmed will download 1.3.4 even though it lists as 1.1.4. Will get this changed.

@yellowianox73
Copy link

yellowianox73 commented Nov 28, 2018 via email

@orofino
Copy link
Author

orofino commented Nov 30, 2018

This is looking good to me! 1.3.4-insider on MacOS Mojave 10.14.1. Thanks for much for adding.

@kburtram
Copy link
Member

kburtram commented Dec 4, 2018

Closing since this feature is available in https://github.com/Microsoft/azuredatastudio/releases/tag/1.3.6 and will be included in the December release planned for 12/12.

@kburtram kburtram closed this as completed Dec 4, 2018
@yualan yualan added the Enhancement Request for new features or functionality label Dec 7, 2018
@sergiokoval
Copy link

doesn't seem it supports "Azure Active Directory - Password" type of authentication. Any plans to have this feature as well?

@sqlarcher
Copy link

doesn't seem it supports "Azure Active Directory - Password" type of authentication. Any plans to have this feature as well?

Unless you have not found it, you can under "Authentication Type" just select "Azure Active Directory - Universal with MFA Support" and this will work the same as "Azure Active Directory - Password". This is available since the December release of Azure Data Studio.

@sergiokoval
Copy link

sergiokoval commented Jan 7, 2019 •
edited
Loading

doesn't seem it supports "Azure Active Directory - Password" type of authentication. Any plans to have this feature as well?

Unless you have not found it, you can under "Authentication Type" just select "Azure Active Directory - Universal with MFA Support" and this will work the same as "Azure Active Directory - Password". This is available since the December release of Azure Data Studio.

thanks for your reply! Yes, I can see that option but it doesn't provide me with entering username/password after. There is empty Account dropdown but no way to type username and password. Was looking for something similar to this window in sql management studio:
image

Am I missing something?

I'm using 1.3.7 insider version.

thanks and best regards

@kburtram
Copy link
Member

kburtram commented Jan 7, 2019

@sergiokoval I'm not sure if that authentication method was implemented in the .Net Core AAD support. @MattIrv do you know the details why we only support "Universal with MFA".

@MattIrv
Copy link
Contributor

MattIrv commented Jan 7, 2019

@sergiokoval The account dropdown that shows up there should have an option to "Add an account", which will open a dialog with instructions on how to log into your account. Is that option missing for you?

@MattIrv
Copy link
Contributor

MattIrv commented Jan 7, 2019

We're also tracking support for password authentication in this issue: #2814. However looking at discussions around username/password auth (e.g. AzureAD/azure-activedirectory-library-for-nodejs#99) it seems like they're pushing for everyone to use web login. So I still need to understand whether there are truly scenarios where users can't use web login and whether our ADAL library actually supports username/password authentication

@sergiokoval
Copy link

sergiokoval commented Jan 8, 2019 •
edited
Loading

hi @MattIrv , the option "Add an account" appeared but nothing happened when I click on it. But after I tried to disconnect from corporate network and switched to regular public connection. So it took me to the device login page eventually.
Seems its not "firewall friendly". However no issues authenticating against azure in other apps using the same methods.
I mean having option to type username/password would be nice addition to user experience.

@adsbot adsbot bot locked and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MattIrv MattIrv

Labels
Area - Connection Enhancement Request for new features or functionality
Projects
None yet
Milestone
January Release
Development

No branches or pull requests