Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constant prompts to access keychain #19269

Open
davemateer opened this issue May 3, 2022 · 10 comments
Open

Constant prompts to access keychain #19269

davemateer opened this issue May 3, 2022 · 10 comments
Labels
Area - Shell Bug Pri: 2 Size: M For a medium complexity issue - only when fixed with a PR Triage: Done
Milestone

Comments

@davemateer
Copy link

Azure Data Studio is constantly prompting to access the keychain whenever connecting to a database. The prompt is:

MicrosoftSqlToolsCredentials wants to use your confidential information stored in "M" in your keychain.

(The letter "M" might be something else ... it seems to vary.)

Even after selecting "Always Allow", I will get the prompt again, sometimes during the same day but certainly the next day. It seems to be often losing access whenever the application is closed, although this isn't 100% repeatable.

No other applications on my laptop (MacBook Pro) are doing this.

@Charles-Gagnon
Copy link
Contributor

Duplicate of this in the STS repo : #22385

@abist @kburtram Is this something we're going to investigate? Do you want to keep an issue open here for tracking or just close it and use the STS one?

@cssuh
Copy link
Member

cssuh commented May 6, 2022

I can take a look at this, I'll keep this one open because I'd like to use the ADS milestones to track this issue.

@cssuh cssuh added this to the June 2022 Release milestone May 6, 2022
@kburtram kburtram modified the milestones: June 2022 Release, Backlog May 31, 2022
@cawGitHub
Copy link

Any news on this ?

@jwatkin
Copy link

jwatkin commented Sep 2, 2022

Did the Visual Studio Code folks find a solution that Azure Data Studio can use?
microsoft/vscode#108342 (comment)

@ottopic
Copy link

ottopic commented Sep 12, 2022

Any news about how to fix it?

@kamalsivalingam
Copy link

Any workarounds for this issue?

@josh-rathke
Copy link

I also have this issue. Would be interested in any fixes

@cssuh cssuh self-assigned this Dec 5, 2022
@cheenamalhotra cheenamalhotra added Pri: 2 Size: M For a medium complexity issue - only when fixed with a PR labels Dec 19, 2022
@stuartpa
Copy link

One issue I've noticed (linked to the the credential being named 'M'), is SqlToolsService is writing the credential name using UTF16 characters (for the M is the first character of the credential name, which starts with the word M i c r o s o f t). (It is also doing the same with the secret, which makes it impossible to display and update the secret using the Keychain UI)

@cheenamalhotra
Copy link
Member

The encoding problem has been fixed, however the issue with repeated prompts is another issue related with how keytar module works with multiple processes, and something to fix at Shell level.

@trangius
Copy link

trangius commented Oct 5, 2023

I am also affected by this issue. Seems to be no workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area - Shell Bug Pri: 2 Size: M For a medium complexity issue - only when fixed with a PR Triage: Done
Projects
None yet
Development

No branches or pull requests