Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LanguageService does not retain active session with server #22970

Closed
cheenamalhotra opened this issue May 4, 2023 · 0 comments · Fixed by #23279
Closed

LanguageService does not retain active session with server #22970

cheenamalhotra opened this issue May 4, 2023 · 0 comments · Fixed by #23279

Comments

@cheenamalhotra
Copy link
Member

Azdata Language service is opening a new connection every time it runs a query, and doesn't retain an active connection session with server. Connection activity tracked with profiler:

image

Discussed offline with @alanrenmsft - it does seem like a bug that should be addressed.

Expected:
Active Connection session is maintained with server similar to azdata-Query connection, that only gets terminated when Query tab is closed.

Impact:
This bug has a large impact on Azure connections, as creating a new connection is very time consuming and expensive. Keeping an active connection from client will prevent recurring connection attempts. Server will terminate the connection when there's no activity after long time, but it will be resiliently reconnected when client tries to execute a query.

P.S. Please make sure connection resiliency is tested on Unix platforms by disconnecting WiFi and reconnecting it. Connection to target server should be re-established without user noticing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment