Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto generated Insights of type count include unwanted JSON #80

Closed
jeffest opened this issue Nov 16, 2017 · 5 comments
Closed

Auto generated Insights of type count include unwanted JSON #80

jeffest opened this issue Nov 16, 2017 · 5 comments

Comments

@jeffest
Copy link

jeffest commented Nov 16, 2017

  • SQL Operations Studio Version: sqlops 0.23.6 (8a3011756318a2ded1e6e84332230a2b2bf9c544, 2017-11-06T21:51:43.232Z)
  • OS Version: Windows_NT x64 6.1.7601

Steps to Reproduce:

  1. Run "SELECT 10 AS ColA"
  2. Go to Chart Viewer
  3. Change type to "count"
  4. Click "Create Insight"

What I see:
"count": {
"dataDirection": "vertical",
"dataType": "number",
"legendPosition": "none",
"labelFirstColumn": false,
"columnsAsLabels": false
}

What I expect:
"count": null

anthonydresser pushed a commit that referenced this issue Dec 18, 2017
Fixes #303, Fixes #304, Fixes #80.
* Context menu support in query component
- All right-click actions in the grid work in the query editor
- Fixed a bug where active grid wasn't reset on new queries. This caused exceptions when a 2nd query had fewer results than the 1st, and you clicked on a grid
- keybinding services do not work yet

* Create parent class for Edit and Query components

* Support Messages context menu

* Fixed queryActions tests failing due to missing promises

* Fix select and copy actions on messages
@EnjoyinMoss
Copy link

Oddly, the tutorial page for custom insights has the incorrect JSON listed in example code and screenshots yet show it to work. Despite that, the bug described above occurs and switching to null or "vertical" does not remedy the lack of text/value in the dashboard grid.

@lzimmermann
Copy link

Hi all, this problem still exists in current build, is there any fix expected?
Version 1.3.9
Date 2019-01-14T23:30:09.442Z
VS Code 1.26.1
Shell 2.0.9
Renderer 61.0.3163.100
Node 8.9.3
V8: 6.1.534.41
Architecture x64

@kburtram
Copy link
Member

@lzimmermann we're planning some improvements in the charting area, though we aren't currently working on this now. This looks like it should be a pretty simple bug we could pick-up before that.

Did switching to "count": null resolve the problem for you?

@kburtram kburtram self-assigned this Feb 13, 2019
@lzimmermann
Copy link

lzimmermann commented Feb 13, 2019 via email

@kburtram
Copy link
Member

Closing older issues. We're moving in a slightly different direction with dashboarding and custom widgets in future releases that will resolve problems such as this.

@adsbot adsbot bot locked and limited conversation to collaborators Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants