Add CodeQL Analysis workflow #10195
Merged
Add CodeQL Analysis workflow #10195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting this one to a draft while we validate the new analysis. |
|
@jhutchings1 are there plans to take this PR out of draft state? |
|
@kburtram Thanks for the ping. This is working well in my fork, so it's good to go whenever you are! |
aaomidi
approved these changes
Jun 17, 2020
v-bbrady
added a commit
that referenced
this pull request
Jun 24, 2020
* builds getting started tour * reorganizes ts according to amirs comments * Fix hygiene issues * updates class names * adds description to new configuration value * uses core components * PR fixes based on Charles comments * formats css * updates guided tour based on charles comments * updates css formatting * fixes read more link * formats gettingStartedTour.ts * updates copy * Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * updates pr based on pr comments * removes unused decleration * formatting * reformats css document * updates file path * updates images Co-authored-by: Amir Omidi <amomidi@microsoft.com> Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
v-bbrady
added a commit
that referenced
this pull request
Jun 29, 2020
* builds getting started tour * reorganizes ts according to amirs comments * Fix hygiene issues * updates class names * adds description to new configuration value * uses core components * PR fixes based on Charles comments * formats css * updates guided tour based on charles comments * updates css formatting * fixes read more link * formats gettingStartedTour.ts * updates copy * Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * updates pr based on pr comments * removes unused decleration * formatting * reformats css document * updates file path * updates images * fixes start button issue * merges master Co-authored-by: Amir Omidi <amomidi@microsoft.com> Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
anthonydresser
pushed a commit
that referenced
this pull request
Jun 29, 2020
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * fix word wrap support in the message panel * fix width on message treee * fix import * fix settings editor to reflect the changes in the settings ids * fix tests * add configuration upgrader * make sure to maintian execution order * make the compiler happy * add tests for upgrader Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
v-bbrady
added a commit
that referenced
this pull request
Jul 6, 2020
* fixes button alignment and missing icons issues with ads welcome page * removes dead code, registers new Button * creates one button component and adds proper attributes depending on platform * Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * adds return types to functions * fixes show all extensions command * formats css * fixes layering issue * updates querySelectors to be more specific Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
aasimkhan30
added a commit
that referenced
this pull request
Jul 9, 2020
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * Fixed the bug where CSVs were treated as TXT files Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
v-bbrady
added a commit
that referenced
this pull request
Jul 17, 2020
… new button dropdown (#11106) * fixes button alignment and missing icons issues with ads welcome page * removes dead code, registers new Button * creates one button component and adds proper attributes depending on platform * Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * adds return types to functions * fixes show all extensions command * updates dropdown color themes * adjusts colors from color registry Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
halerankin
pushed a commit
that referenced
this pull request
Jul 17, 2020
* fixes button alignment and missing icons issues with ads welcome page * removes dead code, registers new Button * creates one button component and adds proper attributes depending on platform * Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * adds return types to functions * fixes show all extensions command * formats css * fixes layering issue * updates querySelectors to be more specific Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
halerankin
pushed a commit
that referenced
this pull request
Jul 17, 2020
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * Fixed the bug where CSVs were treated as TXT files Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
halerankin
pushed a commit
that referenced
this pull request
Jul 17, 2020
… new button dropdown (#11106) * fixes button alignment and missing icons issues with ads welcome page * removes dead code, registers new Button * creates one button component and adds proper attributes depending on platform * Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * adds return types to functions * fixes show all extensions command * updates dropdown color themes * adjusts colors from color registry Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
smartguest
pushed a commit
that referenced
this pull request
Jul 20, 2020
* fixes button alignment and missing icons issues with ads welcome page * removes dead code, registers new Button * creates one button component and adds proper attributes depending on platform * Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * adds return types to functions * fixes show all extensions command * formats css * fixes layering issue * updates querySelectors to be more specific Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
smartguest
pushed a commit
that referenced
this pull request
Jul 20, 2020
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * Fixed the bug where CSVs were treated as TXT files Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
smartguest
pushed a commit
that referenced
this pull request
Jul 20, 2020
… new button dropdown (#11106) * fixes button alignment and missing icons issues with ads welcome page * removes dead code, registers new Button * creates one button component and adds proper attributes depending on platform * Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * adds return types to functions * fixes show all extensions command * updates dropdown color themes * adjusts colors from color registry Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
chlafreniere
pushed a commit
that referenced
this pull request
Jul 28, 2020
* fixes button alignment and missing icons issues with ads welcome page * removes dead code, registers new Button * creates one button component and adds proper attributes depending on platform * Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * adds return types to functions * fixes show all extensions command * formats css * fixes layering issue * updates querySelectors to be more specific Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
ktech99
pushed a commit
that referenced
this pull request
Sep 9, 2020
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * [Kusto extension] Moved Gifs files to resources/images folder * changing image path a 3rd time Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
aasimkhan30
pushed a commit
that referenced
this pull request
Sep 10, 2020
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * [Kusto] Update readme * changed click to select * Add Animated gifs and some text updtes * add link * change in media format syntax * Removed peek definitions * removed all machine learning refs * removed en-us * rename media to images * removed gifs * added back peek definitions * changed media to images * rename folder again and remove azuredatastudio repo link * help whitespace identions * renamed media files * change image format text * removed gifs * add gifs back * edit gulpfile.hygiene.js file to add gifs * fixed image Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
aasimkhan30
pushed a commit
that referenced
this pull request
Sep 10, 2020
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * [Kusto extension] Moved Gifs files to resources/images folder Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
aasimkhan30
pushed a commit
that referenced
this pull request
Sep 10, 2020
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * [Kusto extension] Moved Gifs files to resources/images folder * changing image path a 3rd time Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
aasimkhan30
pushed a commit
that referenced
this pull request
Sep 11, 2020
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * [Kusto] Update readme * changed click to select * Add Animated gifs and some text updtes * add link * change in media format syntax * Removed peek definitions * removed all machine learning refs * removed en-us * rename media to images * removed gifs * added back peek definitions * changed media to images * rename folder again and remove azuredatastudio repo link * help whitespace identions * renamed media files * change image format text * removed gifs * add gifs back * edit gulpfile.hygiene.js file to add gifs * fixed image Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
aasimkhan30
pushed a commit
that referenced
this pull request
Sep 11, 2020
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * [Kusto extension] Moved Gifs files to resources/images folder Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
aasimkhan30
pushed a commit
that referenced
this pull request
Sep 11, 2020
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * [Kusto extension] Moved Gifs files to resources/images folder * changing image path a 3rd time Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
aaomidi
pushed a commit
that referenced
this pull request
Sep 22, 2020
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * updated links * edit line 31 * edit lines 11 and 31 * edit line 11 again Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
halerankin
pushed a commit
that referenced
this pull request
Sep 25, 2020
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * updated links * edit line 31 * edit lines 11 and 31 * edit line 11 again Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
halerankin
added a commit
that referenced
this pull request
Sep 25, 2020
* dashboardWidget to use updated button component - added an enum for buttonType. * Code fixes. * Casting ButtonType to string * Leaving default description value as empty string. Testing logic for buttonType. * Moved ifFile check into buttonType getter. Hard coded button type returns to test on the front end. * revised buttonType getter to return Normal by default if not specified in properties. * Extended sql Button as InfoButton for use in dashboardWidget. * Added InfoButton to ngAfterViewInit * Upadted how infoButton element is built. Exposed properties for use in button.component. * Experiment: Added interface and imported iconUtils for getting iconClass. * infoButton updates * Some modifications * Defined HTMLElements and populated each with properties from dashboardWidget. * Rewrote elements and passed in properties from dashboardWidget to define button contents and layout. * Added missing delineator. * Correctd width getter. * Code cleanup * Styled header and button copy. Corrected button and header dimensions. * Button and welcome page background style adjustments. * infoButton: Added element reference for container coming in via super so I could apply styles to it. Corrected how button renders. * Addressed PR feedback - removed async functionality where not needed. Modified syntax that is being deprecated. Made extended IButtonOptions all optional. * Formatted azdata.proposed. Hygiene check flagged it. * Removing ? and undefined from button properties as all are being passed from dashboard Widget * Initialized private vars representing options from custom interface IInfoButtonOptions. * Addressed PR feedback - added stylesheet for infoButton. Removed iconPath from infoButton context. Cleaned up overall implementation. * Simplified linear-gradient behind main image so it works across all three themes. * Style cleanup. * Removed block notation from element creation in constructor. * Fixed type signature of IInfoButtonOptions. * Removed comments. Shifted infoButton style properties into stylesheet. * Set background color for infoButton when active. This fixes issue where is becomes invisible while selected. * Corrected styles. Removed hard-coded font-colors. Removed unnecessary styles. * CSS - added hover styles to side panel items per Figma comps. Cleaned up CSS and removed code comments. * remove unused splash screen and fix issue reporter path (#12218) * data workspace extension batch 2 (#12208) * work in progress * load projects in view and test cases * update scope * make the sql proj menu available in workspace view * add extension unit test * address comments * fix errors * Add reference to another sql project (#12186) * add projects to add database reference dialog * able to add project references * check for circular dependency * only allow adding reference to project in the same workspace * fix location dropdown when project reference is enabled * add tests * more tests * cleanup * fix flakey test * addressing comments * fix focus order (#12233) * Notebook Text Cell Highlight Improvements (#12197) * 1st iteration * works but multiple highlights * remove comment * Works but multiple selects * wip * cleanup * cleanup * Update TPN * Add mark.js to remote + web * PR feedback * Tweak workbench html files * Add vcore limit support (#12212) * Quick tweaks to resource viewer (v1) (#12210) * Hackathon - Better Markdown Editor (#11540) * Hackathon - better markdown editor - modified Bold to wrap selection in HTML. Split Image button into two new options: embed and link. Made preview container contentEditable. * Removed the new dropdown from Image button -- it is not necessary since we are adding a context panel instead. * Modified preview icons * Set code-component dimensions so it is not visible. It is still being used to pass markdown changes to however. * add turndown and save markdown * update model on UI when source changes * Added conditional that sets element attribute contentEditable when it is in edit mode. * Added textView component that can be used for editing. * update source on MD view not on every keystroke * Added markdown editor buttons that allow user to swap editor, preview views. * Cleaning up implementation * Setting base value of _showPreview to false. * don't allow html edit on split view * Update editor automagically * Add an image picking dialog to notebook toolbar. * Await transformText() * revert pushEditOperations to fix cursor issue * Implemented radio buttons for three view toggles. * Added new, optional properties to radioButton: name, icon class and tooltip. This allows for display as toggleable icon. Updated styles and theme accordingly. * Style tweaks. * Added new ViewAction file where the RadioButton action will reside. * Removed radio button implementation in exchange for native button instantiation. Adjusted CSS and theme accordingly. * Styles, component and template changes to handle view toggle between text, markdownn an splitview. Includes reverting of radioButton as this is no longer used. * WYSIWYG 3 Modes * Ensure one action active at a time * Setting Text View button active by default. Cleaned up styles. Moved toolbar element to prevent code cell layout overflow. * Ensure we respect editMode, add showMarkdown * hiding overflow on code-cell * Empty text container needs 100% width. Eliminates weird selection border too. * Initialize _previewMode * Actions Compatibility * Further toolbar enhancements * Update yarn lock after merge * Slim down changes * Remove commented out code * Added margins around notebook-preview container for more visual space for text * Add turndown to workbench html * Tweak import * Add types/turndown * Remove workbench.html fix * Import cjs modules directly for turndown * Leverage solution from github * browser umd * non browser umd * welp dependency * Modified updatePreview to insert a p tag only when text cell is empty. * add listener for undo * add turndown to remote and web * Fix workbench, check in plugin * PR comment Co-authored-by: maddydev <makoripa@microsoft.com> Co-authored-by: chlafreniere <hichise@gmail.com> Co-authored-by: Cory Rivera <corivera@microsoft.com> Co-authored-by: Lucy Zhang <luczhan@microsoft.com> * Update external repo links (#12226) * Update external repo links * Update yarn files * make schema compare test unstable (#12234) * make schema compare test unstable * also make Standalone database context menu test unstable * Fix missing package update (#12235) * Resource Deployment UX Refresh (#12173) * adding new card to styles * renamed property, removed unnecessary css * Fixed to match new props * added horizontal class * merged from master * Make SandDance work generically for Kusto (#12229) * Make SandDance work generically for Kusto and Postgres * Addressed comments * removed param Co-authored-by: Monica Gupta <mogupt@microsoft.com> * Set items in cell model (#12237) * Change tables to make them work for our scenario (#12193) * Change tables to make them work for our scenario * Comments & deprecate API * Disable selections by default * Have default values in add database dialog input boxes (#12155) * show default values in text boxes * add sqlcmd formatting * add tests * Add some sqlcmd variable name validation * Addressing comments * fixes after merge * fix test * don't localize OtherServer * fix for windows * one more fix * fix test * fix bug that doesn't register double click enabled on new notebook contexts (#12239) * Notebooks: Hide link and image buttons in text cell toolbar in WYSIWYG mode (#12240) * hide link and image buttons in WYSIWYG mode * defined taskbar actions * rename arrays * Notebooks: Add setting for default text cell edit behavior (#12245) * Add setting for default text cell edit behavior * string updates * Fix pinned notebooks navigator (#12246) * Added loading to dropdowns (#12214) * Added loading prop to dropdowns * Added property for setting loading text message * removed unnecessary sets * changed code to match new changes * Changed the dropdown loader to use select component instead of edit. Added missing props in dropdown loader * Address comments jupyter create book notebook (#12250) * Remove toc file link and add warning for windows users * Bump node-fetch from 2.6.0 to 2.6.1 in /build/actions (#12219) Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump node-fetch from 2.6.0 to 2.6.1 in /build (#12220) Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix Notebook Kusto Kernel Consistency (#12256) * fix kusto notebook consistency * Address undefined * add existing project to workspace feature (#12249) * add existing project to workspace feature * update file name * new test and use URI * handle workspace with no folder * add more validation * and more tests * use forward slash * Use correct resource name (#12288) * Add heasdingStyle atx option (#12286) * Disable resource viewer (#12291) * Disable resource viewer * comment * Remove unused * adding icon for add new and open project (#12265) * remove project feature (#12297) * remove project feature * update test * Fix notebook cancel query bug (#12300) * fix undefined query runner error * store connection id * revert sqlSessionManager change * Update PG Deployment with new fields (#12187) * Added 5 missing field options * Missing apostrophe * Change extensions label * Update volume size descriptions * Change volume size labels * Reorder required tools * Reorder required tools * Argument fixes * Removed tabs * Rearrange option order * Rearrange option order * Rearrange option order VS * Added validation to fields. VS accepts only integer and appends Gi * Changed Dusky deployment title * Removed text validation for VS and Mem. Changed to Number field type * Min set to 1 for VS and Mem * Min set to 1 for Cores * Memory limit must be at least 256Mi * the casing of 'preview' should remain consistent * Removed empty line * Portal links for main branch (#12319) * first commit * json field added * message genericized * order changed * removed summary page text * fixed url * controller dropdown field to SQL MIAA and Postgres deployment. (#12217) * saving first draft * throw if no controllers * cleanup * bug fixes * bug fixes and caching controller access * pr comments and bug fixes. * fixes * fixes * comment fix * remove debug prints * comment fixes * remove debug logs * inputValueTransformer returns string|Promise * PR feedback * pr fixes * remove _ from protected fields * anonymous to full methods * small fixes * new postgres model (#12305) Co-authored-by: Brian Bergeron <brberger@microsoft.com> * Nasc/delete instance code removal (#12307) * Formatted page * Removed ResourceHealthPage from the dashboard * Deleted files that no longer applies to the public preview backend * shouldn't be able to open the postgres dashboard * Add new deployment options for MIAA (#12325) * Use custom dialog for prompting MIAA connection info (#12316) * Use custom dialog for prompting MIAA connection info * disable inputs * Update strings * remove data-workspace dependency (#12321) * Arc public preview updates (#12329) * Arc public preview updates * disable PG dashboards again * Stop watching for sqlproj updates after the file is closed (#12311) * stop watching for sqlproj updates after the file is closed * remove watcher if project is closed * Fix component items in declarative table not showing (#12330) * fix maximize bug (#12334) * 12284 Removed custom CSS that positioned editor text beneath overlapping layers. Text is now selectable. (#12312) * Add newline after caption (#12276) * Watch for on load event (#12309) * Update deletion strings to refer to instances instead of resources (#12332) * Update deletion strings to refer to instances instead of resources * one more * Remove unused * More * Fix DT linting issues (#12290) * vbump sql-db-proj extension (#12336) * update sqlproj dependency version (#12359) * Fix highlight issue (#12278) * Fix highlight issue * Address PR comments * remove a import unit test (#12358) * SQL VM deployments (#12144) * Added sql vm deployment option * Added more fields for sql vm deployments * created basic sqlvm deployment. Mostly hardcoded * added string to package.nls * added poc deployments for sql vm * Made some changes in the notebook that was mentioned in PR * Added scaffolding for azure sql vm wizard. * code cleanups * added some async logic * added loading component * fixed loader code * completed page2 of wizard * added some more required fields. * added some more fields * added network settings page * added sql server settings page * added azure signin support and sql server settings page * added some helper methods in wizard code * added some fixes * fixed azure and vm setting page added validation in azure setting page * added changes for the notebook variable * validations and other bug fixes * commenting sql storage optimization dropdown * cleanedup wizard base page * reversing vm image list to display newer images first * cleaning model code * added validations for network setting * Completed summary page fixed the code poisition some additional field validations * fixed networking page * - fixed an error with vm size model variable - removed byol images because it was not working with az sql vm - Fixed vm size display names in dropdown * added double quotes to some localized strings * added some space inside strings * -Added live validations -Restyled network component -Added required to regions -Some bug fixes * -redesigned summary page -localized some strings * Fixed summary page section titles * -Fixed validations on sql server settings page -Fixed some fields on Summary Page * corrected onleave validation using array for error messages using Promises.all * Fixed bug on network settings dropdowns when user does not have existing resource to populate them * Change resource deployment display name Added Ninar's iteration of the notebook Changed RDP check box label Surfacing API errors to user Filtering regions based on Azure VM regions and user's subscription region Made form validation async Displaying new checkbox on network page when dropdowns empty Fixed a small bug in SQL auth form validation Made summary single item per row and fixed the gaps in spacing Fixed validations in vm page Checking if vm name already exists on azure * Fixed sql vm eula Fixed sql vm description Added hyperlink for more info on vm sizes * Replaced loading component with dropdown loaders. * localized string Fixed a bug in network settings page * Added additonal filtering * added reverse to image images * Fixing some merge related issues * Update arc regions for public preview (#12366) * Fix duplicate arc instance nodes (#12381) * Add "No instances available" node for empty arc controllers (#12374) * Remove MIAA Port Deploy Option (#12388) * fix option sources (#12387) * Fix manage action for arc view (#12389) * 12360 Notebook UI - Mac/Win fix for Select all. (#12383) * 12360 Notebook UI - Mac/Win fix for Select all. * Fix for ctrl key selecting all in windows * Fix undo as well * preventDefault to prevent confusing behavior Co-authored-by: chlafreniere <hichise@gmail.com> * Fix notebook table rendering with multiple code cells (#12363) * create unique query runner for each cell * use cellUri instead of cellId to identify runner * disconnect each query runner connection * remove queryrunners size check * Remove azdata eula acceptance from arc deployments (#12292) * saving to switch tasks * activate to exports in extApi * working version - cleanup pending * improve messages * apply pr feedback from a different review * remove unneeded strings * redo apiService * remove async from getVersionFromOutput * remove _ prefix from protected fields * error message fix * throw specif errors from azdata extension * arrow methods to regular methods * pr feedback * expand azdata extension api * pr feedback * remove unused var * pr feedback * Notebooks: Fast update WYSIWYG support for source update (#12289) * Fast update WYSIWYG support for source update * Do bracket matching over hardcoding line offsets * Update Windows command and minor update to installation cell (#12361) * Fix windows command and minor update to installation cell * Add expand_section field on the first section of the book * marking intermittent test failure as unstable (#12402) * Fix connection dialog indentation (#12401) * fix connection dialog indentation * indent tab body * Remove container registry from arc control deploy (#12392) * Fix error when clicking on header for tables with no rows (#12408) * Change default Select query label to "Take 10" for Kusto tables (#12396) * Change default label to "Take 10" for Kusto tables * Addressed comments Co-authored-by: Monica Gupta <mogupt@microsoft.com> * Fix resource deployment text field validation (#12421) * Fix arc deployment regions and remove docker summary (#12430) * start with eulaCheckButton hidden (#12427) * start with eulaCheckButton hidden * reset buttons on card select * remove testcode * fix the legacy card style issue (#12428) * fix the legacy card style issue * replace the card class * Fix Spark kernel connections and switch from Kusto to Spark kernels (#12436) * Fix connection dialog for Spark and issue when switching from Kusto to Spark * Address comments * Add Arc MIAA username configuration (#12429) * Add Arc MIAA username configuration * username -> userName * fix postgres product name (#12443) Co-authored-by: Brian Bergeron <brberger@microsoft.com> * vBump azdata extension (#12452) * Arc - Enable Postgres dashboard (#12439) * get overview, conn strings, properties pages working * hook up password reset, azure link, scale configuration * fix comments * enable opening postgres dashboard from controller dashboard * minor fixes Co-authored-by: Brian Bergeron <brberger@microsoft.com> Co-authored-by: chgagnon <chgagnon@microsoft.com> * Remove ItemGroup from sqlproj if node being removed is the last one (#12398) * remove ItemGroup if node being removed is the only one * fix for if ItemGroup has elements with different tag names * fix for ItemGroups not at the end of the sqlproj * fix the extension dependency issue (#12347) * Bump arc/azdata extension versions (#12463) * Add preview to Arc controller deployment (#12465) * Update azdata extension icon (#12469) * small optimization for select (#12419) * Revert BDC deployment back to using old azdata check (#12470) * remove/use unused strings (#12460) * Activate arc extension with resource deployment command (#12472) * change to allow refresh and delete correctly (#12477) * update resultSet in data provider (#12478) * Add SQL instance name validation (#12480) * Add SQL instance name validation * Move - * Update PG validation * Fix regex * simplify * add table name to models that are imported (#12445) * add table name to models * adding null check for safety * As per PR comment * Arc/Azdata string updates (#12485) * Arc/Azdata string updates * more updates (cherry picked from commit 2c6f7ac) * couple more fixes * more * update sql database projects readme (#12481) * remove option to add reference to same database (#12495) * Update default values and example text when dropdown value changes (#12493) * Fix PySpark kernel connection change (#12494) * Notebooks: Fix Grids Not Rendering when Unsaved Notebook Reloaded (#12483) * Clear Output and fix output change * Fix tests after forced clear + append output * Add warning message for users using the new version of jupyter book (#12496) * Add warning message for users * Address pr comments * Arc Postgres - Add Azure params to overview page, update notebook (#12482) * add azure params to pg overview page, update troubelshooting notebook, string changes * no default pg version for notebook Co-authored-by: Brian Bergeron <brberger@microsoft.com> * Arc good ARC bad (#12499) * default to 0 workers (#12506) Co-authored-by: Brian Bergeron <brberger@microsoft.com> * Add progress indicator for arc instance deletion (#12510) * Fix core and memory request MIAA deploy (#12505) * Fix core and memory request MIAA deploy * Memory request/limit as 2Gi for MIAA * In-Viewlet Notebooks Search (#12455) * fix search * Add sql carbon tags to vs files Co-authored-by: chlafreniere <hichise@gmail.com> Co-authored-by: abist <adbist@microsoft.com> * Replace vCores property with state for arc controller dashboard (#12512) * Bump extensions (#12516) * fix the reference error due to extra $ in default variable (#12523) * use GB instead of MB for postgres memory (#12528) Co-authored-by: Brian Bergeron <brberger@microsoft.com> * data workspace review feedback implementation (#12489) * add a view to handle no workspace scenario * text update * project type filter improvement * fix the project level context menu issue * update strings * Add timestamps to azdata output channel output (#12530) * Fix arc controller ns/name validation (#12525) * Fix arc controller ns/name validation * Rename control plane references * Fix validation * new download location of azdata.msi (#12466) * new download location of azdata.msi * refactor * Disable tests Co-authored-by: chgagnon <chgagnon@microsoft.com> * move eula prompt post azdata discovery (#12532) * new download location of azdata.msi * move eula prompt post azdata discovery * unacceptEula - test change * Revert "unacceptEula - test change" This reverts commit f84a3f5. * Remove Direct connectivity mode option (#12533) * Remove Direct connectivity mode option * remove option completely * fix string * Arc - Update Postgres deployment field labels and descriptions (#12537) * update help text strings * update field descriptions to match help text * update cpu/memory field descriptions Co-authored-by: Brian Bergeron <brberger@microsoft.com> * Add troubleshoot button to arc controller/MIAA dashboard (#12534) * Add troubleshoot button to arc controller dashboard * Add MIAA button * Fix links * Change azdata output channel to Azure Data CLI (#12545) (cherry picked from commit cdd80c6) Co-authored-by: chgagnon <chgagnon@microsoft.com> * Fix windows azdata install (#12542) * Fix windows azdata install * skip failing tests * Update/release docs (#12544) * update changelog for 1.22 * update fwlinks * fix format * escape the value for display (#12547) * Add new profile (#12556) * Add new profile * version * move * fix readonly summary page field widths (#12558) * Arc - Enable Postgres support request link (#12560) Co-authored-by: Brian Bergeron <brberger@microsoft.com> * Add test for notebook result grid streaming (#12539) * start testing convertAllData * add test for convertAllData method * clean up code * bump ads and extensions (#12550) * bump ads and extensions * bump azdata * bump asde deploy * Remove command link from deployment error (#12573) * [Kusto extension] Updated links (#12569) * Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * updated links * edit line 31 * edit lines 11 and 31 * edit line 11 again Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com> * Don't use deprecated param (#12574) * add event.preventDefault() (#12564) * strict compile for sql/workbench/contrib/queryHistory (#12579) * clone the object to be modified (#12583) * Strict compile for sql/workbench/services/dialog (#12578) * Strict compile for sql/workbench/services/dialog * fix errors * strict compile for queryResultsView (#12581) * Add telemetry for ModelView wizards (#12596) * Add telemetry for ModelView wizards * Remove unnecessary params * Fix compile error * Improved behavior for accepting EULA. (#12453) * working version of overloading "select" button * promptForEula to use showErrorMessage * make parameter optional in promptForEula * remove test code * PR feedback * eula to EULA * minor fix * Remove arc deployment extension check (#12598) * add role for history tab (#12608) * add title and tab-index for X button (#12605) * set aria-hidden for a non-visible control (#12607) * Convert MIAA and Postgres deploy from Dialog to NotebookWizard (#12609) * dialog to NotebookWizard * move fields * fix 12599 * pr feedback * add missing page titles * Fix undefined error in server tree data source (#12616) * Fix undefined error in server tree data source * Add comment * Add ModelViewEditorOpened event (#12597) * Add ModelViewEditorOpened event * fix * Fix compile * Update sqltoolservice release for kusto extension (#12622) Co-authored-by: Monica Gupta <mogupt@microsoft.com> * Delete database reference (#12531) * remove ItemGroup if node being removed is the only one * fix for if ItemGroup has elements with different tag names * fix for ItemGroups not at the end of the sqlproj * add delete for db references * fix failing tests * add test * cleanup * Addressing comments and fixing a string * simplify the preview information feature (#12606) * dashboardWidget to use updated button component - added an enum for buttonType. * Code fixes. * Leaving default description value as empty string. Testing logic for buttonType. * revised buttonType getter to return Normal by default if not specified in properties. * Extended sql Button as InfoButton for use in dashboardWidget. * Some modifications * Rewrote elements and passed in properties from dashboardWidget to define button contents and layout. * Styled header and button copy. Corrected button and header dimensions. * Merged latest from main. Resolve conflicts. Co-authored-by: Amir Omidi <amomidi@microsoft.com> Co-authored-by: Aditya Bist <adbist@microsoft.com> Co-authored-by: Alan Ren <alanren@microsoft.com> Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com> Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com> Co-authored-by: maddydev <makoripa@microsoft.com> Co-authored-by: chlafreniere <hichise@gmail.com> Co-authored-by: Cory Rivera <corivera@microsoft.com> Co-authored-by: Lucy Zhang <luczhan@microsoft.com> Co-authored-by: Karl Burtram <karlb@microsoft.com> Co-authored-by: Aasim Khan <aasimkhan30@gmail.com> Co-authored-by: Monica Gupta <scorpio90m@gmail.com> Co-authored-by: Monica Gupta <mogupt@microsoft.com> Co-authored-by: Kartik Arora <33497301+ktech99@users.noreply.github.com> Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vasu Bhog <vabhog@microsoft.com> Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> Co-authored-by: Udeesha Gautam <46980425+udeeshagautam@users.noreply.github.com> Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com> Co-authored-by: Alex Ma <alma1@microsoft.com> Co-authored-by: Arvind Ranasaria <ranasaria@outlook.com> Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com> Co-authored-by: Brian Bergeron <brberger@microsoft.com> Co-authored-by: Mark Ghanayem <22989000+markingmyname@users.noreply.github.com> Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
smartguest
added a commit
that referenced
this pull request
Sep 30, 2020
* Added providerRegistered test * test for EditConnectionDialog * changed wording * added test for connectionInfo * utils.ts tests added * hasRegisteredServers test * commented out editconnection tests, addl. tests * added onConnectionChangedNotification test * added changeGroupId tests * Added connection profile changes * added connectIfNotConnected test * added delete connection test * isRecent and disconnect editor tests * Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * added registerIconProvider test * Fix for ensureDefaultLanguageFlavor test * added a few tests * utils prefix test updated * added utils tests * disconnect tests added * Added additional get connection info tests * added some more tests * minor additions to tests * again another commit * another change * connectionManagementService finalized * connectionDialogWidget test WIP * wip connectiondialogwidget test * added working connectionDialogWidget test * added more tests * current connectionDialogWidget tests * undid space * hanging promise addressed * added open test * finished connectionDialogWidget tests * Added showDialog test * mockConnectionDialogService added * added accessorConnectionDialogService * removed accessor service * added openDialogAndWait test * added fake error to test * added error tests * Added comments to test * more coverage * async to await change * registerCapabilities test added * connectionDialogService tests finished * undefined added * Added views for tests * tslint disable added * error catchers added * added empty connectioninfo Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
smartguest
pushed a commit
that referenced
this pull request
Oct 5, 2020
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * updated links * edit line 31 * edit lines 11 and 31 * edit line 11 again Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
smartguest
added a commit
that referenced
this pull request
Oct 5, 2020
* dashboardWidget to use updated button component - added an enum for buttonType. * Code fixes. * Casting ButtonType to string * Leaving default description value as empty string. Testing logic for buttonType. * Moved ifFile check into buttonType getter. Hard coded button type returns to test on the front end. * revised buttonType getter to return Normal by default if not specified in properties. * Extended sql Button as InfoButton for use in dashboardWidget. * Added InfoButton to ngAfterViewInit * Upadted how infoButton element is built. Exposed properties for use in button.component. * Experiment: Added interface and imported iconUtils for getting iconClass. * infoButton updates * Some modifications * Defined HTMLElements and populated each with properties from dashboardWidget. * Rewrote elements and passed in properties from dashboardWidget to define button contents and layout. * Added missing delineator. * Correctd width getter. * Code cleanup * Styled header and button copy. Corrected button and header dimensions. * Button and welcome page background style adjustments. * infoButton: Added element reference for container coming in via super so I could apply styles to it. Corrected how button renders. * Addressed PR feedback - removed async functionality where not needed. Modified syntax that is being deprecated. Made extended IButtonOptions all optional. * Formatted azdata.proposed. Hygiene check flagged it. * Removing ? and undefined from button properties as all are being passed from dashboard Widget * Initialized private vars representing options from custom interface IInfoButtonOptions. * Addressed PR feedback - added stylesheet for infoButton. Removed iconPath from infoButton context. Cleaned up overall implementation. * Simplified linear-gradient behind main image so it works across all three themes. * Style cleanup. * Removed block notation from element creation in constructor. * Fixed type signature of IInfoButtonOptions. * Removed comments. Shifted infoButton style properties into stylesheet. * Set background color for infoButton when active. This fixes issue where is becomes invisible while selected. * Corrected styles. Removed hard-coded font-colors. Removed unnecessary styles. * CSS - added hover styles to side panel items per Figma comps. Cleaned up CSS and removed code comments. * remove unused splash screen and fix issue reporter path (#12218) * data workspace extension batch 2 (#12208) * work in progress * load projects in view and test cases * update scope * make the sql proj menu available in workspace view * add extension unit test * address comments * fix errors * Add reference to another sql project (#12186) * add projects to add database reference dialog * able to add project references * check for circular dependency * only allow adding reference to project in the same workspace * fix location dropdown when project reference is enabled * add tests * more tests * cleanup * fix flakey test * addressing comments * fix focus order (#12233) * Notebook Text Cell Highlight Improvements (#12197) * 1st iteration * works but multiple highlights * remove comment * Works but multiple selects * wip * cleanup * cleanup * Update TPN * Add mark.js to remote + web * PR feedback * Tweak workbench html files * Add vcore limit support (#12212) * Quick tweaks to resource viewer (v1) (#12210) * Hackathon - Better Markdown Editor (#11540) * Hackathon - better markdown editor - modified Bold to wrap selection in HTML. Split Image button into two new options: embed and link. Made preview container contentEditable. * Removed the new dropdown from Image button -- it is not necessary since we are adding a context panel instead. * Modified preview icons * Set code-component dimensions so it is not visible. It is still being used to pass markdown changes to however. * add turndown and save markdown * update model on UI when source changes * Added conditional that sets element attribute contentEditable when it is in edit mode. * Added textView component that can be used for editing. * update source on MD view not on every keystroke * Added markdown editor buttons that allow user to swap editor, preview views. * Cleaning up implementation * Setting base value of _showPreview to false. * don't allow html edit on split view * Update editor automagically * Add an image picking dialog to notebook toolbar. * Await transformText() * revert pushEditOperations to fix cursor issue * Implemented radio buttons for three view toggles. * Added new, optional properties to radioButton: name, icon class and tooltip. This allows for display as toggleable icon. Updated styles and theme accordingly. * Style tweaks. * Added new ViewAction file where the RadioButton action will reside. * Removed radio button implementation in exchange for native button instantiation. Adjusted CSS and theme accordingly. * Styles, component and template changes to handle view toggle between text, markdownn an splitview. Includes reverting of radioButton as this is no longer used. * WYSIWYG 3 Modes * Ensure one action active at a time * Setting Text View button active by default. Cleaned up styles. Moved toolbar element to prevent code cell layout overflow. * Ensure we respect editMode, add showMarkdown * hiding overflow on code-cell * Empty text container needs 100% width. Eliminates weird selection border too. * Initialize _previewMode * Actions Compatibility * Further toolbar enhancements * Update yarn lock after merge * Slim down changes * Remove commented out code * Added margins around notebook-preview container for more visual space for text * Add turndown to workbench html * Tweak import * Add types/turndown * Remove workbench.html fix * Import cjs modules directly for turndown * Leverage solution from github * browser umd * non browser umd * welp dependency * Modified updatePreview to insert a p tag only when text cell is empty. * add listener for undo * add turndown to remote and web * Fix workbench, check in plugin * PR comment Co-authored-by: maddydev <makoripa@microsoft.com> Co-authored-by: chlafreniere <hichise@gmail.com> Co-authored-by: Cory Rivera <corivera@microsoft.com> Co-authored-by: Lucy Zhang <luczhan@microsoft.com> * Update external repo links (#12226) * Update external repo links * Update yarn files * make schema compare test unstable (#12234) * make schema compare test unstable * also make Standalone database context menu test unstable * Fix missing package update (#12235) * Resource Deployment UX Refresh (#12173) * adding new card to styles * renamed property, removed unnecessary css * Fixed to match new props * added horizontal class * merged from master * Make SandDance work generically for Kusto (#12229) * Make SandDance work generically for Kusto and Postgres * Addressed comments * removed param Co-authored-by: Monica Gupta <mogupt@microsoft.com> * Set items in cell model (#12237) * Change tables to make them work for our scenario (#12193) * Change tables to make them work for our scenario * Comments & deprecate API * Disable selections by default * Have default values in add database dialog input boxes (#12155) * show default values in text boxes * add sqlcmd formatting * add tests * Add some sqlcmd variable name validation * Addressing comments * fixes after merge * fix test * don't localize OtherServer * fix for windows * one more fix * fix test * fix bug that doesn't register double click enabled on new notebook contexts (#12239) * Notebooks: Hide link and image buttons in text cell toolbar in WYSIWYG mode (#12240) * hide link and image buttons in WYSIWYG mode * defined taskbar actions * rename arrays * Notebooks: Add setting for default text cell edit behavior (#12245) * Add setting for default text cell edit behavior * string updates * Fix pinned notebooks navigator (#12246) * Added loading to dropdowns (#12214) * Added loading prop to dropdowns * Added property for setting loading text message * removed unnecessary sets * changed code to match new changes * Changed the dropdown loader to use select component instead of edit. Added missing props in dropdown loader * Address comments jupyter create book notebook (#12250) * Remove toc file link and add warning for windows users * Bump node-fetch from 2.6.0 to 2.6.1 in /build/actions (#12219) Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump node-fetch from 2.6.0 to 2.6.1 in /build (#12220) Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.6.0...v2.6.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix Notebook Kusto Kernel Consistency (#12256) * fix kusto notebook consistency * Address undefined * add existing project to workspace feature (#12249) * add existing project to workspace feature * update file name * new test and use URI * handle workspace with no folder * add more validation * and more tests * use forward slash * Use correct resource name (#12288) * Add heasdingStyle atx option (#12286) * Disable resource viewer (#12291) * Disable resource viewer * comment * Remove unused * adding icon for add new and open project (#12265) * remove project feature (#12297) * remove project feature * update test * Fix notebook cancel query bug (#12300) * fix undefined query runner error * store connection id * revert sqlSessionManager change * Update PG Deployment with new fields (#12187) * Added 5 missing field options * Missing apostrophe * Change extensions label * Update volume size descriptions * Change volume size labels * Reorder required tools * Reorder required tools * Argument fixes * Removed tabs * Rearrange option order * Rearrange option order * Rearrange option order VS * Added validation to fields. VS accepts only integer and appends Gi * Changed Dusky deployment title * Removed text validation for VS and Mem. Changed to Number field type * Min set to 1 for VS and Mem * Min set to 1 for Cores * Memory limit must be at least 256Mi * the casing of 'preview' should remain consistent * Removed empty line * Portal links for main branch (#12319) * first commit * json field added * message genericized * order changed * removed summary page text * fixed url * controller dropdown field to SQL MIAA and Postgres deployment. (#12217) * saving first draft * throw if no controllers * cleanup * bug fixes * bug fixes and caching controller access * pr comments and bug fixes. * fixes * fixes * comment fix * remove debug prints * comment fixes * remove debug logs * inputValueTransformer returns string|Promise * PR feedback * pr fixes * remove _ from protected fields * anonymous to full methods * small fixes * new postgres model (#12305) Co-authored-by: Brian Bergeron <brberger@microsoft.com> * Nasc/delete instance code removal (#12307) * Formatted page * Removed ResourceHealthPage from the dashboard * Deleted files that no longer applies to the public preview backend * shouldn't be able to open the postgres dashboard * Add new deployment options for MIAA (#12325) * Use custom dialog for prompting MIAA connection info (#12316) * Use custom dialog for prompting MIAA connection info * disable inputs * Update strings * remove data-workspace dependency (#12321) * Arc public preview updates (#12329) * Arc public preview updates * disable PG dashboards again * Stop watching for sqlproj updates after the file is closed (#12311) * stop watching for sqlproj updates after the file is closed * remove watcher if project is closed * Fix component items in declarative table not showing (#12330) * fix maximize bug (#12334) * 12284 Removed custom CSS that positioned editor text beneath overlapping layers. Text is now selectable. (#12312) * Add newline after caption (#12276) * Watch for on load event (#12309) * Update deletion strings to refer to instances instead of resources (#12332) * Update deletion strings to refer to instances instead of resources * one more * Remove unused * More * Fix DT linting issues (#12290) * vbump sql-db-proj extension (#12336) * update sqlproj dependency version (#12359) * Fix highlight issue (#12278) * Fix highlight issue * Address PR comments * remove a import unit test (#12358) * SQL VM deployments (#12144) * Added sql vm deployment option * Added more fields for sql vm deployments * created basic sqlvm deployment. Mostly hardcoded * added string to package.nls * added poc deployments for sql vm * Made some changes in the notebook that was mentioned in PR * Added scaffolding for azure sql vm wizard. * code cleanups * added some async logic * added loading component * fixed loader code * completed page2 of wizard * added some more required fields. * added some more fields * added network settings page * added sql server settings page * added azure signin support and sql server settings page * added some helper methods in wizard code * added some fixes * fixed azure and vm setting page added validation in azure setting page * added changes for the notebook variable * validations and other bug fixes * commenting sql storage optimization dropdown * cleanedup wizard base page * reversing vm image list to display newer images first * cleaning model code * added validations for network setting * Completed summary page fixed the code poisition some additional field validations * fixed networking page * - fixed an error with vm size model variable - removed byol images because it was not working with az sql vm - Fixed vm size display names in dropdown * added double quotes to some localized strings * added some space inside strings * -Added live validations -Restyled network component -Added required to regions -Some bug fixes * -redesigned summary page -localized some strings * Fixed summary page section titles * -Fixed validations on sql server settings page -Fixed some fields on Summary Page * corrected onleave validation using array for error messages using Promises.all * Fixed bug on network settings dropdowns when user does not have existing resource to populate them * Change resource deployment display name Added Ninar's iteration of the notebook Changed RDP check box label Surfacing API errors to user Filtering regions based on Azure VM regions and user's subscription region Made form validation async Displaying new checkbox on network page when dropdowns empty Fixed a small bug in SQL auth form validation Made summary single item per row and fixed the gaps in spacing Fixed validations in vm page Checking if vm name already exists on azure * Fixed sql vm eula Fixed sql vm description Added hyperlink for more info on vm sizes * Replaced loading component with dropdown loaders. * localized string Fixed a bug in network settings page * Added additonal filtering * added reverse to image images * Fixing some merge related issues * Update arc regions for public preview (#12366) * Fix duplicate arc instance nodes (#12381) * Add "No instances available" node for empty arc controllers (#12374) * Remove MIAA Port Deploy Option (#12388) * fix option sources (#12387) * Fix manage action for arc view (#12389) * 12360 Notebook UI - Mac/Win fix for Select all. (#12383) * 12360 Notebook UI - Mac/Win fix for Select all. * Fix for ctrl key selecting all in windows * Fix undo as well * preventDefault to prevent confusing behavior Co-authored-by: chlafreniere <hichise@gmail.com> * Fix notebook table rendering with multiple code cells (#12363) * create unique query runner for each cell * use cellUri instead of cellId to identify runner * disconnect each query runner connection * remove queryrunners size check * Remove azdata eula acceptance from arc deployments (#12292) * saving to switch tasks * activate to exports in extApi * working version - cleanup pending * improve messages * apply pr feedback from a different review * remove unneeded strings * redo apiService * remove async from getVersionFromOutput * remove _ prefix from protected fields * error message fix * throw specif errors from azdata extension * arrow methods to regular methods * pr feedback * expand azdata extension api * pr feedback * remove unused var * pr feedback * Notebooks: Fast update WYSIWYG support for source update (#12289) * Fast update WYSIWYG support for source update * Do bracket matching over hardcoding line offsets * Update Windows command and minor update to installation cell (#12361) * Fix windows command and minor update to installation cell * Add expand_section field on the first section of the book * marking intermittent test failure as unstable (#12402) * Fix connection dialog indentation (#12401) * fix connection dialog indentation * indent tab body * Remove container registry from arc control deploy (#12392) * Fix error when clicking on header for tables with no rows (#12408) * Change default Select query label to "Take 10" for Kusto tables (#12396) * Change default label to "Take 10" for Kusto tables * Addressed comments Co-authored-by: Monica Gupta <mogupt@microsoft.com> * Fix resource deployment text field validation (#12421) * Fix arc deployment regions and remove docker summary (#12430) * start with eulaCheckButton hidden (#12427) * start with eulaCheckButton hidden * reset buttons on card select * remove testcode * fix the legacy card style issue (#12428) * fix the legacy card style issue * replace the card class * Fix Spark kernel connections and switch from Kusto to Spark kernels (#12436) * Fix connection dialog for Spark and issue when switching from Kusto to Spark * Address comments * Add Arc MIAA username configuration (#12429) * Add Arc MIAA username configuration * username -> userName * fix postgres product name (#12443) Co-authored-by: Brian Bergeron <brberger@microsoft.com> * vBump azdata extension (#12452) * Arc - Enable Postgres dashboard (#12439) * get overview, conn strings, properties pages working * hook up password reset, azure link, scale configuration * fix comments * enable opening postgres dashboard from controller dashboard * minor fixes Co-authored-by: Brian Bergeron <brberger@microsoft.com> Co-authored-by: chgagnon <chgagnon@microsoft.com> * Remove ItemGroup from sqlproj if node being removed is the last one (#12398) * remove ItemGroup if node being removed is the only one * fix for if ItemGroup has elements with different tag names * fix for ItemGroups not at the end of the sqlproj * fix the extension dependency issue (#12347) * Bump arc/azdata extension versions (#12463) * Add preview to Arc controller deployment (#12465) * Update azdata extension icon (#12469) * small optimization for select (#12419) * Revert BDC deployment back to using old azdata check (#12470) * remove/use unused strings (#12460) * Activate arc extension with resource deployment command (#12472) * change to allow refresh and delete correctly (#12477) * update resultSet in data provider (#12478) * Add SQL instance name validation (#12480) * Add SQL instance name validation * Move - * Update PG validation * Fix regex * simplify * add table name to models that are imported (#12445) * add table name to models * adding null check for safety * As per PR comment * Arc/Azdata string updates (#12485) * Arc/Azdata string updates * more updates (cherry picked from commit 2c6f7ac) * couple more fixes * more * update sql database projects readme (#12481) * remove option to add reference to same database (#12495) * Update default values and example text when dropdown value changes (#12493) * Fix PySpark kernel connection change (#12494) * Notebooks: Fix Grids Not Rendering when Unsaved Notebook Reloaded (#12483) * Clear Output and fix output change * Fix tests after forced clear + append output * Add warning message for users using the new version of jupyter book (#12496) * Add warning message for users * Address pr comments * Arc Postgres - Add Azure params to overview page, update notebook (#12482) * add azure params to pg overview page, update troubelshooting notebook, string changes * no default pg version for notebook Co-authored-by: Brian Bergeron <brberger@microsoft.com> * Arc good ARC bad (#12499) * default to 0 workers (#12506) Co-authored-by: Brian Bergeron <brberger@microsoft.com> * Add progress indicator for arc instance deletion (#12510) * Fix core and memory request MIAA deploy (#12505) * Fix core and memory request MIAA deploy * Memory request/limit as 2Gi for MIAA * In-Viewlet Notebooks Search (#12455) * fix search * Add sql carbon tags to vs files Co-authored-by: chlafreniere <hichise@gmail.com> Co-authored-by: abist <adbist@microsoft.com> * Replace vCores property with state for arc controller dashboard (#12512) * Bump extensions (#12516) * fix the reference error due to extra $ in default variable (#12523) * use GB instead of MB for postgres memory (#12528) Co-authored-by: Brian Bergeron <brberger@microsoft.com> * data workspace review feedback implementation (#12489) * add a view to handle no workspace scenario * text update * project type filter improvement * fix the project level context menu issue * update strings * Add timestamps to azdata output channel output (#12530) * Fix arc controller ns/name validation (#12525) * Fix arc controller ns/name validation * Rename control plane references * Fix validation * new download location of azdata.msi (#12466) * new download location of azdata.msi * refactor * Disable tests Co-authored-by: chgagnon <chgagnon@microsoft.com> * move eula prompt post azdata discovery (#12532) * new download location of azdata.msi * move eula prompt post azdata discovery * unacceptEula - test change * Revert "unacceptEula - test change" This reverts commit f84a3f5. * Remove Direct connectivity mode option (#12533) * Remove Direct connectivity mode option * remove option completely * fix string * Arc - Update Postgres deployment field labels and descriptions (#12537) * update help text strings * update field descriptions to match help text * update cpu/memory field descriptions Co-authored-by: Brian Bergeron <brberger@microsoft.com> * Add troubleshoot button to arc controller/MIAA dashboard (#12534) * Add troubleshoot button to arc controller dashboard * Add MIAA button * Fix links * Change azdata output channel to Azure Data CLI (#12545) (cherry picked from commit cdd80c6) Co-authored-by: chgagnon <chgagnon@microsoft.com> * Fix windows azdata install (#12542) * Fix windows azdata install * skip failing tests * Update/release docs (#12544) * update changelog for 1.22 * update fwlinks * fix format * escape the value for display (#12547) * Add new profile (#12556) * Add new profile * version * move * fix readonly summary page field widths (#12558) * Arc - Enable Postgres support request link (#12560) Co-authored-by: Brian Bergeron <brberger@microsoft.com> * Add test for notebook result grid streaming (#12539) * start testing convertAllData * add test for convertAllData method * clean up code * bump ads and extensions (#12550) * bump ads and extensions * bump azdata * bump asde deploy * Remove command link from deployment error (#12573) * [Kusto extension] Updated links (#12569) * Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * updated links * edit line 31 * edit lines 11 and 31 * edit line 11 again Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com> * Don't use deprecated param (#12574) * add event.preventDefault() (#12564) * strict compile for sql/workbench/contrib/queryHistory (#12579) * clone the object to be modified (#12583) * Strict compile for sql/workbench/services/dialog (#12578) * Strict compile for sql/workbench/services/dialog * fix errors * strict compile for queryResultsView (#12581) * Add telemetry for ModelView wizards (#12596) * Add telemetry for ModelView wizards * Remove unnecessary params * Fix compile error * Improved behavior for accepting EULA. (#12453) * working version of overloading "select" button * promptForEula to use showErrorMessage * make parameter optional in promptForEula * remove test code * PR feedback * eula to EULA * minor fix * Remove arc deployment extension check (#12598) * add role for history tab (#12608) * add title and tab-index for X button (#12605) * set aria-hidden for a non-visible control (#12607) * Convert MIAA and Postgres deploy from Dialog to NotebookWizard (#12609) * dialog to NotebookWizard * move fields * fix 12599 * pr feedback * add missing page titles * Fix undefined error in server tree data source (#12616) * Fix undefined error in server tree data source * Add comment * Add ModelViewEditorOpened event (#12597) * Add ModelViewEditorOpened event * fix * Fix compile * Update sqltoolservice release for kusto extension (#12622) Co-authored-by: Monica Gupta <mogupt@microsoft.com> * Delete database reference (#12531) * remove ItemGroup if node being removed is the only one * fix for if ItemGroup has elements with different tag names * fix for ItemGroups not at the end of the sqlproj * add delete for db references * fix failing tests * add test * cleanup * Addressing comments and fixing a string * simplify the preview information feature (#12606) * dashboardWidget to use updated button component - added an enum for buttonType. * Code fixes. * Leaving default description value as empty string. Testing logic for buttonType. * revised buttonType getter to return Normal by default if not specified in properties. * Extended sql Button as InfoButton for use in dashboardWidget. * Some modifications * Rewrote elements and passed in properties from dashboardWidget to define button contents and layout. * Styled header and button copy. Corrected button and header dimensions. * Merged latest from main. Resolve conflicts. Co-authored-by: Amir Omidi <amomidi@microsoft.com> Co-authored-by: Aditya Bist <adbist@microsoft.com> Co-authored-by: Alan Ren <alanren@microsoft.com> Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com> Co-authored-by: Chris LaFreniere <40371649+chlafreniere@users.noreply.github.com> Co-authored-by: maddydev <makoripa@microsoft.com> Co-authored-by: chlafreniere <hichise@gmail.com> Co-authored-by: Cory Rivera <corivera@microsoft.com> Co-authored-by: Lucy Zhang <luczhan@microsoft.com> Co-authored-by: Karl Burtram <karlb@microsoft.com> Co-authored-by: Aasim Khan <aasimkhan30@gmail.com> Co-authored-by: Monica Gupta <scorpio90m@gmail.com> Co-authored-by: Monica Gupta <mogupt@microsoft.com> Co-authored-by: Kartik Arora <33497301+ktech99@users.noreply.github.com> Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vasu Bhog <vabhog@microsoft.com> Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> Co-authored-by: Udeesha Gautam <46980425+udeeshagautam@users.noreply.github.com> Co-authored-by: nasc17 <69922333+nasc17@users.noreply.github.com> Co-authored-by: Alex Ma <alma1@microsoft.com> Co-authored-by: Arvind Ranasaria <ranasaria@outlook.com> Co-authored-by: Brian Bergeron <brian.e.bergeron@gmail.com> Co-authored-by: Brian Bergeron <brberger@microsoft.com> Co-authored-by: Mark Ghanayem <22989000+markingmyname@users.noreply.github.com> Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
smartguest
added a commit
that referenced
this pull request
Oct 5, 2020
* Added providerRegistered test * test for EditConnectionDialog * changed wording * added test for connectionInfo * utils.ts tests added * hasRegisteredServers test * commented out editconnection tests, addl. tests * added onConnectionChangedNotification test * added changeGroupId tests * Added connection profile changes * added connectIfNotConnected test * added delete connection test * isRecent and disconnect editor tests * Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * added registerIconProvider test * Fix for ensureDefaultLanguageFlavor test * added a few tests * utils prefix test updated * added utils tests * disconnect tests added * Added additional get connection info tests * added some more tests * minor additions to tests * again another commit * another change * connectionManagementService finalized * connectionDialogWidget test WIP * wip connectiondialogwidget test * added working connectionDialogWidget test * added more tests * current connectionDialogWidget tests * undid space * hanging promise addressed * added open test * finished connectionDialogWidget tests * Added showDialog test * mockConnectionDialogService added * added accessorConnectionDialogService * removed accessor service * added openDialogAndWait test * added fake error to test * added error tests * Added comments to test * more coverage * async to await change * registerCapabilities test added * connectionDialogService tests finished * undefined added * Added views for tests * tslint disable added * error catchers added * added empty connectioninfo Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
BranislavGrbicMDCS
added a commit
that referenced
this pull request
Oct 29, 2020
…12824) * Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * Adjusting ADS to support new changes for CloudServerType for SQLOD * Using existing constants instead of hardcoded values * Updating STS version Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
Benjin
pushed a commit
that referenced
this pull request
Oct 30, 2020
…12824) * Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * Adjusting ADS to support new changes for CloudServerType for SQLOD * Using existing constants instead of hardcoded values * Updating STS version Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
JustinMDotNet
pushed a commit
that referenced
this pull request
Nov 4, 2020
…12824) * Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * Adjusting ADS to support new changes for CloudServerType for SQLOD * Using existing constants instead of hardcoded values * Updating STS version Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
Benjin
added a commit
that referenced
this pull request
Jan 22, 2021
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * test commit pls ignore * telemetry points * yarn lock changes * making test xplat friendly * PR feedback * Adding additional telemetry points Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
brian-harris
added a commit
that referenced
this pull request
Jul 28, 2021
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * add assessment warnings info * add migration assessment blocking issue warnings * update grid column widths * remove unexpected change * adding learn more link Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
stuti149
pushed a commit
that referenced
this pull request
Aug 1, 2021
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * add assessment warnings info * add migration assessment blocking issue warnings * update grid column widths * remove unexpected change * adding learn more link Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
rajeshka
pushed a commit
that referenced
this pull request
Aug 2, 2021
* Add CodeQL Analysis workflow * Fix path
rajeshka
added a commit
that referenced
this pull request
Aug 2, 2021
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * Fixed UI regression in main * removed the file which should not been included * Addressed PR comments * Addressed PR Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
Benjin
pushed a commit
that referenced
this pull request
Aug 11, 2021
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * Fixed UI regression in main * removed the file which should not been included * Addressed PR comments * Addressed PR Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
JustinMDotNet
pushed a commit
that referenced
this pull request
Oct 6, 2021
* Add CodeQL Analysis workflow * Fix path
brian-harris
added a commit
that referenced
this pull request
Apr 7, 2022
This reverts commit fe98d58.
brian-harris
added a commit
that referenced
this pull request
Apr 12, 2022
* Add CodeQL Analysis workflow (#10195) * Add CodeQL Analysis workflow * Fix path * dashboard refactor * update version, readme, minor ui changes * fix merge issue * Revert "Add CodeQL Analysis workflow (#10195)" This reverts commit fe98d58. * fix context switching issue * fix resource id parsing error and mi api version * mv refresh btn, rm autorefresh, align cards * remove missed autorefresh code * improve error handling and messages * fix typos * remove duplicate/unnecessary _populate* calls * change clear configuration button text * remove confusing watermark text * add stale account handling Co-authored-by: Justin Hutchings <jhutchings1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new GitHub action.