Copy dacpac to temp folder before publishing to avoid dacpac lock #11036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisantia
approved these changes
Jun 22, 2020
| should(deployedDacpacPath).not.equal('', 'deployed dacpac path should be set'); | ||
| should(builtDacpacPath).not.equal(deployedDacpacPath, 'built and deployed dacpac paths should be different'); | ||
| should(postCopyContents).equal(fakeDacpacContents, 'contents of built and deployed dacpacs should match'); | ||
| }); |
There was a problem hiding this comment.
should the created files get deleted at the end of the test?
There was a problem hiding this comment.
Intentionally not cleaned up at the end of the test; instead all files created with these test utils are in some folder under temp. This way, you can physically check files during/after test runs if something's gone awry, but they get cleaned up on the OS's own time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work-around for #10589, not calling it "fixed" since we still haven't identified the source of the lock.