Markdown Horizontal Scrollbar Fix #17083

VasuBhog · 2021-09-15T10:39:44Z

This PR fixes #14483 & fixes #15943.

This PR addresses the horizontal scrollbar issues users see when they have word wrap off in the split view for markdown cells. Every time the user updates the layout (either from editing the cell, scrolling the terminal window over the cell, or making the ADS smaller in resolution) we have to set the horizontal scrollbar accordingly. The way we can identify whether to set the horizontal to a fixed position is only by comparing the markdown editor space to that of the scrollable space. This required additional offset values as well in order to get a precise comparison.

horizontal_scrollbar2.mp4

coveralls · 2021-09-15T10:56:35Z

Pull Request Test Coverage Report for Build 1279938806

2 of 35 (5.71%) changed or added relevant lines in 4 files are covered.
1136 unchanged lines in 25 files lost coverage.
Overall coverage decreased (-0.04%) to 41.627%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/sql/workbench/services/notebook/browser/models/notebookModel.ts	1	2	50.0%
src/sql/workbench/contrib/notebook/browser/notebook.component.ts	0	3	0.0%
src/sql/workbench/browser/modelComponents/queryTextEditor.ts	1	5	20.0%
src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts	0	25	0.0%

Files with Coverage Reduction	New Missed Lines	%
src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts	1	4.18%
extensions/import/src/common/constants.ts	2	96.88%
extensions/import/src/services/features.ts	4	0%
extensions/sql-database-projects/src/tools/packageHelper.ts	4	78.26%
extensions/import/src/wizard/pages/summaryPage.ts	6	84.62%
extensions/import/src/wizard/pages/modifyColumnsPage.ts	8	68.09%
extensions/import/src/wizard/flatFileWizard.ts	9	84.54%
extensions/sql-database-projects/src/dialogs/publishDatabaseQuickpick.ts	9	4.32%
extensions/sql-database-projects/src/dialogs/deployDatabaseQuickpick.ts	11	10.34%
extensions/sql-database-projects/src/common/azureFunctionsUtils.ts	15	16.13%

Totals
Change from base Build 1235658581:	-0.04%
Covered Lines:	26588
Relevant Lines:	57868

💛 - Coveralls

lucyzhang929 · 2021-09-15T15:02:39Z

The horizontal scrollbar appears when it is not needed (ex. no text in cell yet) and persists after I scroll past the cell:

Screen.Recording.2021-09-15.at.7.21.40.AM.mov

Maybe looking at the way the horizontal scrollbar is implemented in query editor would be helpful here.

src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts

VasuBhog · 2021-09-15T17:57:11Z

The horizontal scrollbar appears when it is not needed (ex. no text in cell yet) and persists after I scroll past the cell:

Screen.Recording.2021-09-15.at.7.21.40.AM.mov
Maybe looking at the way the horizontal scrollbar is implemented in query editor would be helpful here.

Forgot to mention the current corner case of the scrolling not updating the horizontal scrollbar. Currently looking into that, as it seems it goes still display past the cell only if there is a markdown cell after it.
The query editor utilizes the exact same scrollbar mechanism (from vs code) as we do for the editor but the issue here is that they have only one editor viewport (visible area) therefore they never have to worry about where to place the scrollbar since it is always at the bottom of the editor window due to the position being absolute.

chlafreniere · 2021-09-17T21:13:06Z

@VasuBhog are you working through any more issues, or is this considered feature complete for now?

VasuBhog · 2021-09-17T21:15:33Z

@VasuBhog are you working through any more issues, or is this considered feature complete for now?

@chlafreniere Just doing thorough testing. One last issue I believe to be an empty markdown cell and ensuring the different scrolling mechanisms (scroll wheel vs scrollbar) set the horizontal scrollbar properly.

src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts

halerankin

Left minor feedback

src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts

VasuBhog · 2021-09-22T22:02:21Z

@microsoft/azure-data-studio-notebook-devs please review when you have time. All layout/position of editor scenarios are taken into account: scrolling via mouse wheel and scroll bar, terminal window overlapping cell, ADS window resolution changes, and sidebar open/close.

src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts

chlafreniere · 2021-09-23T00:08:35Z

src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts

+			} else {
+				horizontalScrollbar.style.opacity = '1';
+				horizontalScrollbar.style.position = 'fixed';
+				horizontalScrollbar.style.left = '';


What's the difference between 0px left style and an empty string left style?

The main reason for this is due to the vs code horizontal scrollbar setting the "fixed" horizontal scenario to be 0px as well. If that is the case it would be all the way on the left side near our sidebar panel (notebooks, source control, extensions, etc icons). As a result, we need to make sure when we switch between the two scenarios we set them appropriately based on whether the scrollbar is fixed or not.

chlafreniere · 2021-09-23T00:12:56Z

src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts

+	 * or it will set it to the bottom of the markdown editor if it is in the viewport (visible area)
+	 */
+	public horizontalScrollbar(): void {
+		if (this._configurationService.getValue('editor.wordWrap') === 'off' && this.cellModel.cellType !== CellTypes.Code && this.cellModel.source.length > 0) {


Should this logic be triggered for every markdown editing type (and regardless of editing/preview mode)?

I can discuss this with Julie, as I believe that users will also see these problems when editing markdown as well. They would have to scroll down every time to see the horizontal scrollbar if the bottom of the editor is not visible.

Ok. What about wysiwyg?

Discussed offline. WYSIWYG word wrap support is low pri as of now.

src/sql/workbench/contrib/notebook/browser/notebook.component.ts

lucyzhang929

Screen.Recording.2021-09-23.at.7.25.28.AM.mov

Couple of things:

The scrollbar seems to be positioned a little too high (it is above the last line of text).
Do we want to show the horizontal scrollbar even when its not needed?

VasuBhog · 2021-09-23T19:06:36Z

Screen.Recording.2021-09-23.at.7.25.28.AM.mov
Couple of things:

The scrollbar seems to be positioned a little too high (it is above the last line of text).

Do we want to show the horizontal scrollbar even when its not needed?

@lucyzhang929

We have to set the scrollbar higher as there is potentially another scrollbar that can be shown if you shorten the ADS window (another horizontal scrollbar) when the internal editor has a fixed scrollbar which if we had made it lower would not have a clear enough difference between the horizontal scrollbars. Discussed this with Design and they said if it's over some text but is transparent it should be fine. Can get more feedback.
I believe that we can make some modifications here, but we are unable to leverage the vs code mechanics that were currently established for when to show the scrollbar or not as it would also break other scenarios.

src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts

* dynamically change horizontal scrollbar * working horizontal scrollbar * created new event to handle both scrollbar and mouse wheel * only show scrollbar when needed

* wip * wire up e2e * hook up styler and add as dataprotocal feature * designer child component rendering * table component updates * styler and selectbox column editor * fix editor size and dupe component creation issue * fix checkbox column and add more testing data * properties pane * only rerender when needed * properties pane update * update commands * cleanup for PR * revert unwanted changes * Adding a few tests for Add SQL binding (#17079) * initial changes * add a couple more tests * LEGO: check in for main to temporary branch. (#17089) * LEGO: check in for main to temporary branch. (#17091) Co-authored-by: kburtram <karlb@microsoft.com> * Adds autorest-based SQL Project generation to SQL Database Projects extension (#17078) * Initial changes * checkpoint * Constructing project with post deployment script * Correcting to intentionally read from cached list of projects * Adding activation event, fixing fresh workspace bug * Convert netcoreTool and autorestHelper to share a helper class for streamed command * Include npm package version to force update * test checkpoint * Unit tests * Added contextual quickpicks for autorest dialogs * Adding projectController test * Added projectController test, some refactoring for testability * Merge branch 'main' into benjin/autorest * Fixing 'which' import * PR feedback * Fixing tests * Adding additional information for when project provider tests fail * Hopefully fixing failing tests (unable to repro locally) * Adding Generate Project item to workspace menu * PR feedback * LEGO: check in for main to temporary branch. (#17097) * added sql database projects strings (#17100) * Set kernelAlias in startSession when isValidConnection is truthy (#17102) * PR follow-up comments (#17113) * Change recompare message after changing options to modal (#17103) * Change recompare message to modal * change options to yes and no * Remove commented code block in git extension (#17116) * Remove commented code block in git extension * Add SQL CARBON EDIT tag * [Loc] Small change to generatingProjectFailed (#17118) * Add Null Shortcut and added NULL text for default NULL value. (#17085) * added test key event * added null function to tryHandleKeyEvent * added null formatting * added working null insert. * added editDataGridPanel string null support * Bump nth-check from 2.0.0 to 2.0.1 in /build (#17115) Bumps [nth-check](https://github.com/fb55/nth-check) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/fb55/nth-check/releases) - [Commits](fb55/nth-check@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: nth-check dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add excludeFlags to extenson marketplace query (#17121) * Add excludeFlags to extenson marketplace query * Remove dead code * Remove extraneous blank line * Address code review feedback * Adding Derived Columns to ADS Flatfile Import (#16795) * Adding derived column boilerplate * brandan preliminary frontend changes * empty commit * added new param * updating contracts, dialogue changes * utils changes, saving timeout attempt * pushing for aasim * Cleaning up code and fixing the issue in theory * changing button, did not solve independent scroll * Fixing the scroll bar issue * updating flat file service * adding override keyword to overrriden method * improving UI * pushing changes associated with resolved comments * localizing strings, editing comments * all comments resolved * Fixing a test * updating import package Updating azure MFA bug * Clearing navigation validator Fixing broken table name change * fixed prose test * removing unused code from tests * Fixed PR comments * Fixing some PR comments * WIP * Fixing transformation code and create derived column dialog styling * removing unused code * Adding comment for console log * fixed table styling * Adding some aria labels * Fixed some code cleanup issues * update import service Co-authored-by: Aasim Khan <aasimkhan30@gmail.com> Co-authored-by: bnhoule <t-bhoule@microsoft.com> * Change keybindings for copying query with Results (#17127) Co-authored-by: Monica Gupta <mogupt@microsoft.com> * sql proj - publish to docker improvements (#17124) * Add AAD token expiration handling for query runner (#17117) * Add AAD token refresh for notebook * move token refresh to query management and remove previous refresh calls * Add guids to RunAll and RunCell events (#17123) Add guids to RunAll and RunCell events * add error banner for failed migration cutover and cancel migration (#17106) * [Loc] update to sql migration, database projects and import extension strings (#17130) * Apply optional storage class settings in sql mi create command (#17129) * Make storage classes optional * Fix notebook to use storage class options Co-authored-by: Charmaine Chan <chachan@microsoft.com> * Add support for adding new setting in local.settings.json in add SQL binding quickpick (#17093) * be able to add new setting in local.settings.json * cleanup * addressing comments * remove todo comment * addressing comments * update some strings to uris * bump version of sqltoolsservice (#17133) * mark schema compare tests as unstable (#17140) * [Loc] Update for arc and sql-database-projects (#17148) * ML extension vbump (#17143) * Configure docker image and web smoke tests for ADSWeb. (#17136) * Adjusts timeout period * Revert "Adjusts timeout period" This reverts commit 0f372ea. * Adds firefox as browser option * Corrects yaml smoke test script * Resets args array to original values * Corrects build path * Resolves ignoring browser option error * continue even after writing to stderr * Adjusts smoke test (browser) script * More adjustments to smoke test script * Corrects server path * Uses build variable directly in build path * Specifies browser type since cannot be ignored error * Adds browser option * Updates web build image and corrects smoke test exe command * Removes commented out task * Updates dockerfile to support web smoketests * Removes failOnStderr flag * Use curl instead of wget in Dockerfile * Fixed a bug with cancling publish (#17160) * Save And Close Functionality (#17000) * save and close * wip * working save and close * cleanup * pr changes * pr changes * fix capitalization * fix build * pr fix * Added dynamic options for SQL MIAA Deployment Wizard and updated checkbox field (#17119) * Dynamic enablement * Added new package.json field for dynamic options and corresponding functions and classes. * Enabled dynamic options non-generalized and changed formatting of checkbox to have label on the left. * Added setOptions under InputComponentInfo for generalization, comments under checkbox component, and changed Replicas to High Availability to reflect parity in portal. * fix unit test Co-authored-by: Candice Ye <canye@microsoft.com> Co-authored-by: Alan Ren <alanren@microsoft.com> * LEGO: check in for main to temporary branch. (#17168) * [Loc] added new arc strings and fix for sql-database-projects lcl file for Japanese (#17171) * [Loc] added new arc strings and fix for sql-database-projects xlf * removed newline * Port of Vscode fix for colors too close (#17146) * default light colors list.focusHighlightForeground too close to list.activeSelectionBackground. Fixes #127597 * remove activeSelectionBackground from theme-carbon as it conflicts with vscode. * remove dark carbon background Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> * Markdown Horizontal Scrollbar Fix (#17083) * dynamically change horizontal scrollbar * working horizontal scrollbar * created new event to handle both scrollbar and mouse wheel * only show scrollbar when needed * LEGO: check in for main to temporary branch. (#17181) * Bump axios to 0.21.4 (#17161) * Kusto version bump to 0.5.6 (#17114) * Bumped Kusto toolsservice version to 125 and bumped version to 0.5.6 * Changed netcoreapp3.1 to net5.0 in Kusto config.json * AzureMonitor bump ToolService version and extension version. (#17174) * Bump concat-with-sourcemaps from 1.0.4 to 1.1.0 (#17158) Bumps [concat-with-sourcemaps](https://github.com/floridoo/concat-with-sourcemaps) from 1.0.4 to 1.1.0. - [Release notes](https://github.com/floridoo/concat-with-sourcemaps/releases) - [Commits](https://github.com/floridoo/concat-with-sourcemaps/commits) --- updated-dependencies: - dependency-name: concat-with-sourcemaps dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update service downloader to 0.2.3 (#17186) * Notebook Views grid fixes (#17170) * update data workspace restart ADS to open workspace message (#17188) * update message * update string * Add back "Remove Project" (#17178) * remove project working with full paths * use relative paths * const * addressing comments * Bump github-auth axios to 0.21.4 (#17189) * LEGO: check in for main to temporary branch. (#17192) * LEGO: check in for main to temporary branch. (#17190) Co-authored-by: kburtram <karlb@microsoft.com> * [Loc] Add a small change to dataworkspace (#17194) * added bump to sqltoolsservice version (#17195) * Check if file is dirty before adding sql binding (#17175) * check if file is dirty before adding sql binding * Addressing comments * Add vertical scroll bar to Preview in Split View (#17164) * reset max height * add editor height * set md editor height * Split up NotebookProvider into separate providers for handling file serialization and cell execution. (#17176) * fix floating promises * pr comments * reuse component definition * comments * fix error Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com> Co-authored-by: csigs <csigs@users.noreply.github.com> Co-authored-by: kburtram <karlb@microsoft.com> Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com> Co-authored-by: Alex Ma <alma1@microsoft.com> Co-authored-by: Justin M <63619224+JustinMDotNet@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: bnhoule <52506119+bnhoule@users.noreply.github.com> Co-authored-by: Aasim Khan <aasimkhan30@gmail.com> Co-authored-by: bnhoule <t-bhoule@microsoft.com> Co-authored-by: Monica Gupta <scorpio90m@gmail.com> Co-authored-by: Monica Gupta <mogupt@microsoft.com> Co-authored-by: Leila Lali <llali@microsoft.com> Co-authored-by: Hai Cao <hacao@microsoft.com> Co-authored-by: Daniel Grajeda <dagrajed@microsoft.com> Co-authored-by: brian-harris <61598682+brian-harris@users.noreply.github.com> Co-authored-by: Charmaine Chan <69230572+charmainewkchan@users.noreply.github.com> Co-authored-by: Charmaine Chan <chachan@microsoft.com> Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com> Co-authored-by: Christopher Suh <chsuh@microsoft.com> Co-authored-by: Candice Ye <candiceye@berkeley.edu> Co-authored-by: Candice Ye <canye@microsoft.com> Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> Co-authored-by: Vasu Bhog <vabhog@microsoft.com> Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com> Co-authored-by: Cory Rivera <corivera@microsoft.com>

* dynamically change horizontal scrollbar * working horizontal scrollbar * created new event to handle both scrollbar and mouse wheel * only show scrollbar when needed

* wip * wire up e2e * hook up styler and add as dataprotocal feature * designer child component rendering * table component updates * styler and selectbox column editor * fix editor size and dupe component creation issue * fix checkbox column and add more testing data * properties pane * only rerender when needed * properties pane update * update commands * cleanup for PR * revert unwanted changes * Adding a few tests for Add SQL binding (microsoft#17079) * initial changes * add a couple more tests * LEGO: check in for main to temporary branch. (microsoft#17089) * LEGO: check in for main to temporary branch. (microsoft#17091) Co-authored-by: kburtram <karlb@microsoft.com> * Adds autorest-based SQL Project generation to SQL Database Projects extension (microsoft#17078) * Initial changes * checkpoint * Constructing project with post deployment script * Correcting to intentionally read from cached list of projects * Adding activation event, fixing fresh workspace bug * Convert netcoreTool and autorestHelper to share a helper class for streamed command * Include npm package version to force update * test checkpoint * Unit tests * Added contextual quickpicks for autorest dialogs * Adding projectController test * Added projectController test, some refactoring for testability * Merge branch 'main' into benjin/autorest * Fixing 'which' import * PR feedback * Fixing tests * Adding additional information for when project provider tests fail * Hopefully fixing failing tests (unable to repro locally) * Adding Generate Project item to workspace menu * PR feedback * LEGO: check in for main to temporary branch. (microsoft#17097) * added sql database projects strings (microsoft#17100) * Set kernelAlias in startSession when isValidConnection is truthy (microsoft#17102) * PR follow-up comments (microsoft#17113) * Change recompare message after changing options to modal (microsoft#17103) * Change recompare message to modal * change options to yes and no * Remove commented code block in git extension (microsoft#17116) * Remove commented code block in git extension * Add SQL CARBON EDIT tag * [Loc] Small change to generatingProjectFailed (microsoft#17118) * Add Null Shortcut and added NULL text for default NULL value. (microsoft#17085) * added test key event * added null function to tryHandleKeyEvent * added null formatting * added working null insert. * added editDataGridPanel string null support * Bump nth-check from 2.0.0 to 2.0.1 in /build (microsoft#17115) Bumps [nth-check](https://github.com/fb55/nth-check) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/fb55/nth-check/releases) - [Commits](fb55/nth-check@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: nth-check dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add excludeFlags to extenson marketplace query (microsoft#17121) * Add excludeFlags to extenson marketplace query * Remove dead code * Remove extraneous blank line * Address code review feedback * Adding Derived Columns to ADS Flatfile Import (microsoft#16795) * Adding derived column boilerplate * brandan preliminary frontend changes * empty commit * added new param * updating contracts, dialogue changes * utils changes, saving timeout attempt * pushing for aasim * Cleaning up code and fixing the issue in theory * changing button, did not solve independent scroll * Fixing the scroll bar issue * updating flat file service * adding override keyword to overrriden method * improving UI * pushing changes associated with resolved comments * localizing strings, editing comments * all comments resolved * Fixing a test * updating import package Updating azure MFA bug * Clearing navigation validator Fixing broken table name change * fixed prose test * removing unused code from tests * Fixed PR comments * Fixing some PR comments * WIP * Fixing transformation code and create derived column dialog styling * removing unused code * Adding comment for console log * fixed table styling * Adding some aria labels * Fixed some code cleanup issues * update import service Co-authored-by: Aasim Khan <aasimkhan30@gmail.com> Co-authored-by: bnhoule <t-bhoule@microsoft.com> * Change keybindings for copying query with Results (microsoft#17127) Co-authored-by: Monica Gupta <mogupt@microsoft.com> * sql proj - publish to docker improvements (microsoft#17124) * Add AAD token expiration handling for query runner (microsoft#17117) * Add AAD token refresh for notebook * move token refresh to query management and remove previous refresh calls * Add guids to RunAll and RunCell events (microsoft#17123) Add guids to RunAll and RunCell events * add error banner for failed migration cutover and cancel migration (microsoft#17106) * [Loc] update to sql migration, database projects and import extension strings (microsoft#17130) * Apply optional storage class settings in sql mi create command (microsoft#17129) * Make storage classes optional * Fix notebook to use storage class options Co-authored-by: Charmaine Chan <chachan@microsoft.com> * Add support for adding new setting in local.settings.json in add SQL binding quickpick (microsoft#17093) * be able to add new setting in local.settings.json * cleanup * addressing comments * remove todo comment * addressing comments * update some strings to uris * bump version of sqltoolsservice (microsoft#17133) * mark schema compare tests as unstable (microsoft#17140) * [Loc] Update for arc and sql-database-projects (microsoft#17148) * ML extension vbump (microsoft#17143) * Configure docker image and web smoke tests for ADSWeb. (microsoft#17136) * Adjusts timeout period * Revert "Adjusts timeout period" This reverts commit 0f372ea. * Adds firefox as browser option * Corrects yaml smoke test script * Resets args array to original values * Corrects build path * Resolves ignoring browser option error * continue even after writing to stderr * Adjusts smoke test (browser) script * More adjustments to smoke test script * Corrects server path * Uses build variable directly in build path * Specifies browser type since cannot be ignored error * Adds browser option * Updates web build image and corrects smoke test exe command * Removes commented out task * Updates dockerfile to support web smoketests * Removes failOnStderr flag * Use curl instead of wget in Dockerfile * Fixed a bug with cancling publish (microsoft#17160) * Save And Close Functionality (microsoft#17000) * save and close * wip * working save and close * cleanup * pr changes * pr changes * fix capitalization * fix build * pr fix * Added dynamic options for SQL MIAA Deployment Wizard and updated checkbox field (microsoft#17119) * Dynamic enablement * Added new package.json field for dynamic options and corresponding functions and classes. * Enabled dynamic options non-generalized and changed formatting of checkbox to have label on the left. * Added setOptions under InputComponentInfo for generalization, comments under checkbox component, and changed Replicas to High Availability to reflect parity in portal. * fix unit test Co-authored-by: Candice Ye <canye@microsoft.com> Co-authored-by: Alan Ren <alanren@microsoft.com> * LEGO: check in for main to temporary branch. (microsoft#17168) * [Loc] added new arc strings and fix for sql-database-projects lcl file for Japanese (microsoft#17171) * [Loc] added new arc strings and fix for sql-database-projects xlf * removed newline * Port of Vscode fix for colors too close (microsoft#17146) * default light colors list.focusHighlightForeground too close to list.activeSelectionBackground. Fixes #127597 * remove activeSelectionBackground from theme-carbon as it conflicts with vscode. * remove dark carbon background Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> * Markdown Horizontal Scrollbar Fix (microsoft#17083) * dynamically change horizontal scrollbar * working horizontal scrollbar * created new event to handle both scrollbar and mouse wheel * only show scrollbar when needed * LEGO: check in for main to temporary branch. (microsoft#17181) * Bump axios to 0.21.4 (microsoft#17161) * Kusto version bump to 0.5.6 (microsoft#17114) * Bumped Kusto toolsservice version to 125 and bumped version to 0.5.6 * Changed netcoreapp3.1 to net5.0 in Kusto config.json * AzureMonitor bump ToolService version and extension version. (microsoft#17174) * Bump concat-with-sourcemaps from 1.0.4 to 1.1.0 (microsoft#17158) Bumps [concat-with-sourcemaps](https://github.com/floridoo/concat-with-sourcemaps) from 1.0.4 to 1.1.0. - [Release notes](https://github.com/floridoo/concat-with-sourcemaps/releases) - [Commits](https://github.com/floridoo/concat-with-sourcemaps/commits) --- updated-dependencies: - dependency-name: concat-with-sourcemaps dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update service downloader to 0.2.3 (microsoft#17186) * Notebook Views grid fixes (microsoft#17170) * update data workspace restart ADS to open workspace message (microsoft#17188) * update message * update string * Add back "Remove Project" (microsoft#17178) * remove project working with full paths * use relative paths * const * addressing comments * Bump github-auth axios to 0.21.4 (microsoft#17189) * LEGO: check in for main to temporary branch. (microsoft#17192) * LEGO: check in for main to temporary branch. (microsoft#17190) Co-authored-by: kburtram <karlb@microsoft.com> * [Loc] Add a small change to dataworkspace (microsoft#17194) * added bump to sqltoolsservice version (microsoft#17195) * Check if file is dirty before adding sql binding (microsoft#17175) * check if file is dirty before adding sql binding * Addressing comments * Add vertical scroll bar to Preview in Split View (microsoft#17164) * reset max height * add editor height * set md editor height * Split up NotebookProvider into separate providers for handling file serialization and cell execution. (microsoft#17176) * fix floating promises * pr comments * reuse component definition * comments * fix error Co-authored-by: Kim Santiago <31145923+kisantia@users.noreply.github.com> Co-authored-by: csigs <csigs@users.noreply.github.com> Co-authored-by: kburtram <karlb@microsoft.com> Co-authored-by: Benjin Dubishar <benjin.dubishar@gmail.com> Co-authored-by: Alex Ma <alma1@microsoft.com> Co-authored-by: Justin M <63619224+JustinMDotNet@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: bnhoule <52506119+bnhoule@users.noreply.github.com> Co-authored-by: Aasim Khan <aasimkhan30@gmail.com> Co-authored-by: bnhoule <t-bhoule@microsoft.com> Co-authored-by: Monica Gupta <scorpio90m@gmail.com> Co-authored-by: Monica Gupta <mogupt@microsoft.com> Co-authored-by: Leila Lali <llali@microsoft.com> Co-authored-by: Hai Cao <hacao@microsoft.com> Co-authored-by: Daniel Grajeda <dagrajed@microsoft.com> Co-authored-by: brian-harris <61598682+brian-harris@users.noreply.github.com> Co-authored-by: Charmaine Chan <69230572+charmainewkchan@users.noreply.github.com> Co-authored-by: Charmaine Chan <chachan@microsoft.com> Co-authored-by: Lewis Sanchez <87730006+lewis-sanchez@users.noreply.github.com> Co-authored-by: Christopher Suh <chsuh@microsoft.com> Co-authored-by: Candice Ye <candiceye@berkeley.edu> Co-authored-by: Candice Ye <canye@microsoft.com> Co-authored-by: Martin Aeschlimann <martinae@microsoft.com> Co-authored-by: Vasu Bhog <vabhog@microsoft.com> Co-authored-by: Charles Gagnon <chgagnon@microsoft.com> Co-authored-by: Barbara Valdez <34872381+barbaravaldez@users.noreply.github.com> Co-authored-by: Cory Rivera <corivera@microsoft.com>

VasuBhog added 6 commits September 2, 2021 14:52

initial css change

9968b40

dynamically change horizontal scrollbar

54967d4

working horizontal scrollbar

9adf279

few tweaks on horizontal switch between fixed and absolute

980646a

comment tweaks

d248d31

update comments

f650ff0

VasuBhog requested review from halerankin and a team September 15, 2021 10:39

halerankin reviewed Sep 15, 2021

View reviewed changes

src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts Outdated Show resolved Hide resolved

halerankin reviewed Sep 15, 2021

View reviewed changes

src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts Outdated Show resolved Hide resolved

address scroll wheel fix

5eda00a

fix empty text cell and use rounding

bfb3a02

halerankin reviewed Sep 17, 2021

View reviewed changes

src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts Outdated Show resolved Hide resolved

halerankin reviewed Sep 17, 2021

View reviewed changes

src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts Outdated Show resolved Hide resolved

halerankin reviewed Sep 20, 2021

View reviewed changes

src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts Outdated Show resolved Hide resolved

VasuBhog added 3 commits September 20, 2021 17:21

created new event to handle both scrollbar and mouse wheel

808d84f

remove HostListener

8640938

Fine tuning scrollbar issues

37c1240

VasuBhog requested a review from halerankin September 22, 2021 21:45

halerankin approved these changes Sep 22, 2021

View reviewed changes

src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts Show resolved Hide resolved

update comment

10af687

chlafreniere reviewed Sep 23, 2021

View reviewed changes

lucyzhang929 reviewed Sep 23, 2021

View reviewed changes

VasuBhog added 2 commits September 24, 2021 02:59

address position concerns

d09f9fe

only show scrollbar when needed

0f5662a

VasuBhog requested review from alanrenmsft and Charles-Gagnon as code owners September 24, 2021 23:56

VasuBhog added 2 commits September 24, 2021 17:04

on delete set showScrollbar to false

9eacf63

remove scrollbar when deleting

b8cdc7c

lucyzhang929 approved these changes Sep 27, 2021

View reviewed changes

src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts Outdated Show resolved Hide resolved

src/sql/workbench/contrib/notebook/browser/cellViews/code.component.ts Outdated Show resolved Hide resolved

update comments

45efcdf

VasuBhog merged commit db1d3cc into main Sep 27, 2021

VasuBhog deleted the vabhog/markdownHorizontalBar branch September 27, 2021 23:54

alanrenmsft pushed a commit that referenced this pull request Sep 29, 2021

Markdown Horizontal Scrollbar Fix (#17083)

fd38713

* dynamically change horizontal scrollbar * working horizontal scrollbar * created new event to handle both scrollbar and mouse wheel * only show scrollbar when needed

Charles-Gagnon mentioned this pull request Oct 4, 2023

Ignore Code type cells in horizontalScrollbar #24576

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Markdown Horizontal Scrollbar Fix #17083

Markdown Horizontal Scrollbar Fix #17083

VasuBhog commented Sep 15, 2021 •

edited by Charles-Gagnon

coveralls commented Sep 15, 2021 •

edited

lucyzhang929 commented Sep 15, 2021

VasuBhog commented Sep 15, 2021

chlafreniere commented Sep 17, 2021

VasuBhog commented Sep 17, 2021

halerankin left a comment

VasuBhog commented Sep 22, 2021

chlafreniere Sep 23, 2021

VasuBhog Sep 23, 2021

chlafreniere Sep 23, 2021

VasuBhog Sep 23, 2021

chlafreniere Sep 24, 2021

VasuBhog Sep 27, 2021

lucyzhang929 left a comment

VasuBhog commented Sep 23, 2021

Markdown Horizontal Scrollbar Fix #17083

Markdown Horizontal Scrollbar Fix #17083

Conversation

VasuBhog commented Sep 15, 2021 • edited by Charles-Gagnon

coveralls commented Sep 15, 2021 • edited

Pull Request Test Coverage Report for Build 1279938806

💛 - Coveralls

lucyzhang929 commented Sep 15, 2021

VasuBhog commented Sep 15, 2021

chlafreniere commented Sep 17, 2021

VasuBhog commented Sep 17, 2021

halerankin left a comment

Choose a reason for hiding this comment

VasuBhog commented Sep 22, 2021

chlafreniere Sep 23, 2021

Choose a reason for hiding this comment

VasuBhog Sep 23, 2021

Choose a reason for hiding this comment

chlafreniere Sep 23, 2021

Choose a reason for hiding this comment

VasuBhog Sep 23, 2021

Choose a reason for hiding this comment

chlafreniere Sep 24, 2021

Choose a reason for hiding this comment

VasuBhog Sep 27, 2021

Choose a reason for hiding this comment

lucyzhang929 left a comment

Choose a reason for hiding this comment

VasuBhog commented Sep 23, 2021

VasuBhog commented Sep 15, 2021 •

edited by Charles-Gagnon

coveralls commented Sep 15, 2021 •

edited