Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number of rows affected/queried #1714

Closed
wants to merge 8 commits into from
Closed

Number of rows affected/queried #1714

wants to merge 8 commits into from

Conversation

grishRodCas
Copy link

@grishRodCas grishRodCas commented Jun 22, 2018 •
edited

Please make the number of rows affected/queried appear in the bottom bar, just like SQL Management Studio does.... and/or remember manual changes if the same query is re-run.

image

Anthony Dresser and others added 5 commits June 20, 2018 16:56
Accessibility enhancements (#1678)
9d2b206 
* adds aria-label to inputs for connection

* formatting

* add ariaLabels to all checkboxes/inputboxes/dropdowns

* fix labels on database dropdown action

* fix compile errors

* remove unnecessary code
@MattIrv
Add info/warning/error messages for wizards and dialogs (#1696)
f5b147c
@llali
Feature/form improvements (#1707)
1871fd3 
* adding more options for form

* added form requied and info for item
@MattIrv
Add dialog close validation (#1704)
6c5fac9
@alanrenmsft
fix dropdown component issue (#1709)
3228474 
* fix dropdown component issue

* handle enable property default
@msftclas
Copy link

msftclas commented Jun 22, 2018 •
edited

CLA assistant check
All CLA requirements met.

@kburtram
Copy link
Member

@anthonydresser could you please work with @grishRodCas to get this PR merged?

@kburtram
Copy link
Member

kburtram commented Jun 22, 2018 •
edited

@grishRodCas could you please add a screenshot or two highlighting the UI that's being changed? That's really helpful to visualize what the code changes are doing. Thanks!

It looks like the PR may have some edits unrelated to your change. If so, could you please remerge the latest changes from master so your changes can be viewed in isolation.

@anthonydresser
Copy link
Contributor

@grishRodCas it looks like you didn't choose the right branches to merge. The base branch of the merge should be master of this repo and the compare branch should be which ever branch you have your changes on in your fork.

llali and others added 2 commits June 22, 2018 14:25
@llali
Feature/selectable card component (#1703)
a627285 
* added selectable card

* creating new card type
Modifying angular bootstrap to add injection at the module level (#1691)
473ddfc 
* work on fixing injection

* change bootstrapping method

* add a catch for testing

* remove unneeded code
@grishRodCas
Copy link
Author

grishRodCas commented Jun 23, 2018 via email •
edited

@kburtram
Copy link
Member

@grishRodCas thanks for the screenshot? Could you please clarify if this PR is supposed to add the feature you're proposing? Or are you trying to suggest we add the feature?

If the PR contains the implementation of the feature could you please rebase or merge master so that only you're changes are included in the diff? If this is for suggestion purposes then we can track the request through this issue #1713. Thanks!

@grishRodCas
Copy link
Author

grishRodCas commented Jun 25, 2018 via email

@kburtram
Copy link
Member

@grishRodCas thanks for confirming! In this case, I'll close this PR now and we'll track the request in the active issue (we use the PRs to track proposed implementations).

@kburtram kburtram closed this Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthonydresser anthonydresser Awaiting requested review from anthonydresser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@grishRodCas @msftclas @kburtram @anthonydresser @MattIrv @llali @alanrenmsft