Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve account and tenant selection error handling #17476

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

brian-harris
Copy link
Contributor

This PR

  • improves error handling for account/tenant selection
  • improves error handling for resourceGroup list loading

@coveralls
Copy link

coveralls commented Oct 23, 2021

Pull Request Test Coverage Report for Build 1382427409

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 30 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.0007%) to 41.476%

Files with Coverage Reduction New Missed Lines %
src/sql/platform/theme/common/styler.ts 2 26.25%
src/sql/workbench/browser/modal/optionsDialog.ts 28 9.01%
Totals Coverage Status
Change from base Build 1374289843: 0.0007%
Covered Lines: 26849
Relevant Lines: 58741

💛 - Coveralls

@brian-harris brian-harris merged commit aa0e52c into main Oct 25, 2021
@brian-harris brian-harris deleted the dev/brih/bugs/fix-location-selection branch October 25, 2021 19:26
brian-harris added a commit that referenced this pull request Oct 25, 2021
* improve account/tenant selection error handling

* remove extra space from user string
kburtram pushed a commit that referenced this pull request Oct 26, 2021
* improve account/tenant selection error handling

* remove extra space from user string
languy pushed a commit to languy/azuredatastudio that referenced this pull request Nov 17, 2021
* improve account/tenant selection error handling

* remove extra space from user string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants