Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not being able to type in code cell after switching from text (#1… #17592

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

chlafreniere
Copy link
Contributor

…7590)

  • Fix not being able to type in code cell after switching from text

This PR fixes #17579

Note: this hasn't been approved for release yet, opportunistically opening this if/when it's approved.

…7590)

* Fix not being able to type in code cell after switching from text

* comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1419636153

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 41.509%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sql/workbench/contrib/notebook/browser/cellViews/textCell.component.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/sql/workbench/services/connection/browser/connectionDialogWidget.ts 1 75.1%
Totals Coverage Status
Change from base Build 1414212838: 0.002%
Covered Lines: 26840
Relevant Lines: 58674

💛 - Coveralls

@chlafreniere chlafreniere merged commit 0b9ef71 into release/1.33 Nov 4, 2021
@chlafreniere chlafreniere deleted the port/17590 branch November 4, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants