Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port fix for db role member in user management #23148

Merged
merged 1 commit into from May 16, 2023
Merged

Conversation

caohai
Copy link
Member

@caohai caohai commented May 16, 2023

This PR fixes #23143
STS PR to main: microsoft/sqltoolsservice#2068
STS Port PR: microsoft/sqltoolsservice#2069
Change since last STS version: microsoft/sqltoolsservice@4.7.1.3...4.7.1.4 The above PR is the only change got in.

I've verified the fix with this STS build.

Copy link
Member

@kburtram kburtram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the final planned STS bump can we also update vscode-mssql with the same version?

@caohai
Copy link
Member Author

caohai commented May 16, 2023

Since this is the final planned STS bump can we also update vscode-mssql with the same version?

@kburtram Sure I can send a PR to vscode-mssql release branch with this build.

@kburtram kburtram merged commit 31bee67 into release/1.44 May 16, 2023
7 checks passed
@kburtram kburtram deleted the hacao/portSTS branch May 16, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants