Fix flaky ADS unit tests by using DOM rendering #23770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewis-sanchez
changed the title
lewis-sanchez
changed the title
kisantia
reviewed
Jul 11, 2023
src/vs/platform/configuration/test/common/testConfigurationService.ts
Outdated
Show resolved
Hide resolved
kisantia
reviewed
Jul 11, 2023
src/vs/platform/configuration/test/common/testConfigurationService.ts
Outdated
Show resolved
Hide resolved
| @@ -18,6 +18,23 @@ export class TestConfigurationService implements IConfigurationService { | |||
| readonly onDidChangeConfiguration = this.onDidChangeConfigurationEmitter.event; | |||
|
|
|||
| constructor(configuration?: any) { | |||
| // {{SQL CARBON EDIT}} - START | |||
There was a problem hiding this comment.
Did vscode run into the same issue?
There was a problem hiding this comment.
@Charles-Gagnon, do you know if VS Code ran into a similar issue? I don't know all the details around the conversation with Daniel from VS Code.
There was a problem hiding this comment.
I don't believe so, or at least I've never seen them having any issues in their tests and Daniel didn't say anything about fixing it on their side.
My best guess was that it was something with the container they're running their tests in - they have their own custom container and many of the scripts they run are different from ours so something there might be our
I did try updating to the latest xterm packages but that didn't solve it either unfortunately.
kisantia
approved these changes
Jul 11, 2023
Charles-Gagnon
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Thanks for taking care of this @lewis-sanchez! Fingers crossed it helps....
lewis-sanchez
added a commit
that referenced
this pull request
Jul 11, 2023
* Makes use of xvfb to run unit tests * Restore test script as before, but with xvfb * Use same command that worked in CLI * Add --build CLI arg * Add coverage arg * Revert change to core unit test script * Reset core unit tests script in linux pipeline * Revert "Skip flaky vscode test suites (#23535)" This reverts commit 882bdb3. * Revert "Disable failing vscode test suite (#23539)" This reverts commit 562a0ce. * Revert "Disable vscode remote configuration suite (#23545)" This reverts commit 40fa1ce. * Revert "Disable editor resolver service test suite (#23550)" This reverts commit cd68dca. * Revert "Disable upstream extension enablement suite (#23557)" This reverts commit faf3c69. * Revert "Skip a few more suites impacted by xterm issue (#23589)" This reverts commit 1662ced. # Conflicts: # src/vs/workbench/contrib/experiments/test/electron-sandbox/experimentService.test.ts * Use DOM Renderer for tests * Remove extra whitespace * Update comment
kisantia
pushed a commit
that referenced
this pull request
Jul 11, 2023
* Makes use of xvfb to run unit tests * Restore test script as before, but with xvfb * Use same command that worked in CLI * Add --build CLI arg * Add coverage arg * Revert change to core unit test script * Reset core unit tests script in linux pipeline * Revert "Skip flaky vscode test suites (#23535)" This reverts commit 882bdb3. * Revert "Disable failing vscode test suite (#23539)" This reverts commit 562a0ce. * Revert "Disable vscode remote configuration suite (#23545)" This reverts commit 40fa1ce. * Revert "Disable editor resolver service test suite (#23550)" This reverts commit cd68dca. * Revert "Disable upstream extension enablement suite (#23557)" This reverts commit faf3c69. * Revert "Skip a few more suites impacted by xterm issue (#23589)" This reverts commit 1662ced. # Conflicts: # src/vs/workbench/contrib/experiments/test/electron-sandbox/experimentService.test.ts * Use DOM Renderer for tests * Remove extra whitespace * Update comment
lewis-sanchez
added a commit
that referenced
this pull request
Jul 17, 2023
This reverts commit 952bab7.
lewis-sanchez
added a commit
that referenced
this pull request
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #23509
This PR fixes an issue with our flaky unit tests that are caused because DOM rendering isn't being used. The fix is temporary and will most likely need to be removed once GPU accelerating is working again in xterm. This PR also reenables all tests that were skipped previously.