-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky ADS unit tests by using DOM rendering #23770
Conversation
src/vs/platform/configuration/test/common/testConfigurationService.ts
Outdated
Show resolved
Hide resolved
src/vs/platform/configuration/test/common/testConfigurationService.ts
Outdated
Show resolved
Hide resolved
@@ -18,6 +18,23 @@ export class TestConfigurationService implements IConfigurationService { | |||
readonly onDidChangeConfiguration = this.onDidChangeConfigurationEmitter.event; | |||
|
|||
constructor(configuration?: any) { | |||
// {{SQL CARBON EDIT}} - START |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did vscode run into the same issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Charles-Gagnon, do you know if VS Code ran into a similar issue? I don't know all the details around the conversation with Daniel from VS Code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe so, or at least I've never seen them having any issues in their tests and Daniel didn't say anything about fixing it on their side.
My best guess was that it was something with the container they're running their tests in - they have their own custom container and many of the scripts they run are different from ours so something there might be our
I did try updating to the latest xterm packages but that didn't solve it either unfortunately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this @lewis-sanchez! Fingers crossed it helps....
* Makes use of xvfb to run unit tests * Restore test script as before, but with xvfb * Use same command that worked in CLI * Add --build CLI arg * Add coverage arg * Revert change to core unit test script * Reset core unit tests script in linux pipeline * Revert "Skip flaky vscode test suites (#23535)" This reverts commit 882bdb3. * Revert "Disable failing vscode test suite (#23539)" This reverts commit 562a0ce. * Revert "Disable vscode remote configuration suite (#23545)" This reverts commit 40fa1ce. * Revert "Disable editor resolver service test suite (#23550)" This reverts commit cd68dca. * Revert "Disable upstream extension enablement suite (#23557)" This reverts commit faf3c69. * Revert "Skip a few more suites impacted by xterm issue (#23589)" This reverts commit 1662ced. # Conflicts: # src/vs/workbench/contrib/experiments/test/electron-sandbox/experimentService.test.ts * Use DOM Renderer for tests * Remove extra whitespace * Update comment
* Makes use of xvfb to run unit tests * Restore test script as before, but with xvfb * Use same command that worked in CLI * Add --build CLI arg * Add coverage arg * Revert change to core unit test script * Reset core unit tests script in linux pipeline * Revert "Skip flaky vscode test suites (#23535)" This reverts commit 882bdb3. * Revert "Disable failing vscode test suite (#23539)" This reverts commit 562a0ce. * Revert "Disable vscode remote configuration suite (#23545)" This reverts commit 40fa1ce. * Revert "Disable editor resolver service test suite (#23550)" This reverts commit cd68dca. * Revert "Disable upstream extension enablement suite (#23557)" This reverts commit faf3c69. * Revert "Skip a few more suites impacted by xterm issue (#23589)" This reverts commit 1662ced. # Conflicts: # src/vs/workbench/contrib/experiments/test/electron-sandbox/experimentService.test.ts * Use DOM Renderer for tests * Remove extra whitespace * Update comment
This reverts commit 952bab7.
This PR fixes #23509
This PR fixes an issue with our flaky unit tests that are caused because DOM rendering isn't being used. The fix is temporary and will most likely need to be removed once GPU accelerating is working again in xterm. This PR also reenables all tests that were skipped previously.