Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Notebook toolbar and cell toolbar dropdown alignment #23870

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

lucyzhang929
Copy link
Contributor

Addresses: #23826
Dropdowns in cell toolbar:
Screenshot 2023-07-13 at 2 57 24 PM
Screenshot 2023-07-13 at 2 57 20 PM

Dropdowns in notebooks toolbar:
Screenshot 2023-07-13 at 2 57 16 PM
Screenshot 2023-07-13 at 2 57 10 PM

@lucyzhang929 lucyzhang929 requested a review from a team July 13, 2023 22:05
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this changed in the merge?

@lucyzhang929
Copy link
Contributor Author

Our code wasn't changed but there were changes in the VSCode dropdown.ts which probably affected these dropdowns.

@lucyzhang929 lucyzhang929 merged commit 9c43a37 into main Jul 14, 2023
9 checks passed
@lucyzhang929 lucyzhang929 deleted the luczhan/fixnbdropdownalignment branch July 14, 2023 00:56
lucyzhang929 added a commit that referenced this pull request Jul 14, 2023
chlafreniere pushed a commit that referenced this pull request Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants