-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPID to toolbar #24679
Add SPID to toolbar #24679
Conversation
src/sql/workbench/contrib/connection/browser/connectionStatus.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/contrib/connection/browser/connectionStatus.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/contrib/connection/browser/connectionStatus.ts
Outdated
Show resolved
Hide resolved
please make sure this is only displayed when the spid is available, other providers won't have this information at the beginning. also it would be nice to adjust comments to make it more generic and allow extensions to provider their own preferred display name instead of hardcoding it to spid. |
for example: in Postgres it is called PID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we not going to allow providers to specify the text/name to display then?
@cheenamalhotra Can you take a look and make sure all the latest changes look good to you? |
src/sql/workbench/contrib/connection/browser/connectionStatus.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/contrib/connection/browser/connectionStatus.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/contrib/connection/browser/connectionStatus.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/contrib/connection/browser/connectionStatus.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/contrib/connection/browser/connectionStatus.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/contrib/connection/browser/connectionStatus.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/contrib/connection/browser/connectionStatus.ts
Outdated
Show resolved
Hide resolved
Change connection status description Co-authored-by: Charles Gagnon <chgagnon@microsoft.com>
src/sql/workbench/services/connection/browser/connectionManagementService.ts
Show resolved
Hide resolved
src/sql/platform/connection/test/common/testConnectionManagementService.ts
Show resolved
Hide resolved
@smartguest, @cheenamalhotra How can I integrate this solution into my ADS Program? |
If you're working with MSSQL provider, and you're listening to |
Adds the SPID of the current connection/editor to the bottom right bar, similar to SSMS, added as part of the connection status (in it's own section though):
Images:
Default connection SPID:
Query Editor (showing editor SPID):
Non Query-Related connections/databases selected on Object Explorer:
Fixes: #229
Companion PRs:
microsoft/sqltoolsservice#2269
microsoft/sqlops-dataprotocolclient#97