-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving Restore functionality to the mssql extension #24757
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corivera
reviewed
Oct 23, 2023
Pull Request Test Coverage Report for Build 7010405392Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
extensions/mssql/src/objectManagement/objectManagementService.ts
Outdated
Show resolved
Hide resolved
Is the gif you have in the original description still accurate with the long delay for opening? Please update it if not |
Update: Added new video. |
Charles-Gagnon
approved these changes
Nov 22, 2023
corivera
reviewed
Nov 27, 2023
corivera
reviewed
Nov 27, 2023
extensions/mssql/src/objectManagement/ui/restoreDatabaseDialog.ts
Outdated
Show resolved
Hide resolved
corivera
reviewed
Nov 27, 2023
extensions/mssql/src/objectManagement/ui/restoreDatabaseDialog.ts
Outdated
Show resolved
Hide resolved
corivera
reviewed
Nov 27, 2023
extensions/mssql/src/objectManagement/ui/restoreDatabaseDialog.ts
Outdated
Show resolved
Hide resolved
corivera
reviewed
Nov 27, 2023
extensions/mssql/src/objectManagement/ui/restoreDatabaseDialog.ts
Outdated
Show resolved
Hide resolved
corivera
reviewed
Nov 27, 2023
extensions/mssql/src/objectManagement/ui/restoreDatabaseDialog.ts
Outdated
Show resolved
Hide resolved
corivera
reviewed
Nov 27, 2023
extensions/mssql/src/objectManagement/ui/restoreDatabaseDialog.ts
Outdated
Show resolved
Hide resolved
corivera
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR for the Restore dialog
This PR contains the changes of creating and opening a new OM restore dialog that gets the pre-defined values from the mssql and restores the database with the selected available options.