-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Migration Experience] Add updating Default data collection path in extension settings #24793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krritik
changed the title
add setting default data collection path in extension settings
[New Migration Experience] Add updating Default data collection path in extension settings
Oct 27, 2023
Pull Request Test Coverage Report for Build 6836463930
💛 - Coveralls |
krritik
requested review from
AkshayMata,
raymondtruong,
brian-harris and
junierch
as code owners
October 27, 2023 07:20
brian-harris
approved these changes
Oct 27, 2023
stuti149
approved these changes
Oct 30, 2023
extensions/sql-migration/src/wizard/skuRecommendation/skuDataCollectionToolbar.ts
Outdated
Show resolved
Hide resolved
extensions/sql-migration/src/wizard/skuRecommendation/skuDataCollectionToolbar.ts
Outdated
Show resolved
Hide resolved
@cpichuka, Do we want to take this in current release? |
extensions/sql-migration/src/wizard/skuRecommendation/skuDataCollectionToolbar.ts
Outdated
Show resolved
Hide resolved
brian-harris
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can now update the default path for Data collection at Extension Settings.
Extension Settings changes -
DataCollection starts at "%userprofile%\AppData\Roaming\azuredatastudio\PerfData"
DataCollection starts at "%userprofile%\AppData\Roaming\azuredatastudio\PerfData"
DataCollection starts at user given path.