Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Migration Experience] Add updating Default data collection path in extension settings #24793

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

krritik
Copy link
Contributor

@krritik krritik commented Oct 27, 2023

User can now update the default path for Data collection at Extension Settings.

Extension Settings changes -
image

  1. If user does not set path in Extension Settings -
    DataCollection starts at "%userprofile%\AppData\Roaming\azuredatastudio\PerfData"
  2. If user set path in Extension Settings and path does not exist -
    DataCollection starts at "%userprofile%\AppData\Roaming\azuredatastudio\PerfData"
  3. If user set path in Extension Settings and path exists -
    DataCollection starts at user given path.

@krritik krritik changed the title add setting default data collection path in extension settings [New Migration Experience] Add updating Default data collection path in extension settings Oct 27, 2023
@coveralls
Copy link

coveralls commented Oct 27, 2023

Pull Request Test Coverage Report for Build 6836463930

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 41.568%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePathPage.ts 1 57.02%
Totals Coverage Status
Change from base Build 6828665189: -0.002%
Covered Lines: 30784
Relevant Lines: 69355

💛 - Coveralls

@krritik krritik marked this pull request as ready for review October 27, 2023 07:20
@krritik
Copy link
Contributor Author

krritik commented Oct 31, 2023

@cpichuka, Do we want to take this in current release?

@krritik krritik merged commit 152a1c8 into main Nov 14, 2023
10 of 12 checks passed
@krritik krritik deleted the krritik/updateExtensionPathSQL branch November 14, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants