-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SQL Migration] Import Assessments #24811
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a Integration and Condition Handling (#24378) * integration of assessment summary * adding removed strings
Pull Request Test Coverage Report for Build 6867785268Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
extensions/sql-migration/src/wizard/assessmentDetailsPage/assessmentDetailsHeader.ts
Outdated
Show resolved
Hide resolved
extensions/sql-migration/src/wizard/assessmentDetailsPage/assessmentDetailsHeader.ts
Outdated
Show resolved
Hide resolved
brian-harris
approved these changes
Oct 31, 2023
siyao-Siyang
reviewed
Nov 1, 2023
siyao-Siyang
reviewed
Nov 1, 2023
siyao-Siyang
reviewed
Nov 1, 2023
siyao-Siyang
reviewed
Nov 1, 2023
extensions/sql-migration/src/wizard/assessmentDetailsPage/assessmentDetailsHeader.ts
Show resolved
Hide resolved
Ramudaykumar
reviewed
Nov 6, 2023
Ramudaykumar
reviewed
Nov 6, 2023
extensions/sql-migration/src/dialog/assessment/assessmentUtils.ts
Outdated
Show resolved
Hide resolved
Ramudaykumar
reviewed
Nov 6, 2023
krritik
reviewed
Nov 7, 2023
extensions/sql-migration/src/wizard/assessmentDetailsPage/treeComponent.ts
Show resolved
Hide resolved
krritik
reviewed
Nov 7, 2023
krritik
approved these changes
Nov 14, 2023
siyao-Siyang
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Enables a feature to import saved assessments (DMA and SQL Migration extension in JSON format) at users end.
The button to import assessments is provided on dashboard. Experience to show the assessments is in sync with new migration experience.
Screenshots:
![image](https://private-user-images.githubusercontent.com/87131830/278949954-da3ed9c3-acd2-496b-8786-40b96b392158.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1ODAyNDAsIm5iZiI6MTcyMDU3OTk0MCwicGF0aCI6Ii84NzEzMTgzMC8yNzg5NDk5NTQtZGEzZWQ5YzMtYWNkMi00OTZiLTg3ODYtNDBiOTZiMzkyMTU4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEwVDAyNTIyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWIxNzIyOGVlNDgxZGNmMzE2Y2NjY2RiZGZiZGRhYmZlOTliNTQ2Mzc3MzgwMjIxYjdkNDgzYzZjMWMxNDg4YjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.clOc7IyQAf40YYXbIvLUU1XnVGB9IJAly_Y-5BtZCwA)
SQL migration extension report import:
![image](https://private-user-images.githubusercontent.com/87131830/278950131-a1760ff3-c9d9-4be5-9925-3966fbc25540.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1ODAyNDAsIm5iZiI6MTcyMDU3OTk0MCwicGF0aCI6Ii84NzEzMTgzMC8yNzg5NTAxMzEtYTE3NjBmZjMtYzlkOS00YmU1LTk5MjUtMzk2NmZiYzI1NTQwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEwVDAyNTIyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRlNDEzNTRmNDJkYWU3MGVlZjQwNWYyZDNmMmI2NDY2NzFlZGNkMDU3NDU3YzVmYjQ2N2MxOTE1OWQzMzVmYjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Nsth4b_SbhpDUepvBetSX8j0KHPYvR2s2swsf3R7Lpc)
DMA report import:
![image](https://private-user-images.githubusercontent.com/87131830/278950467-e82b0504-8da4-4514-8038-3d622bb55a15.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA1ODAyNDAsIm5iZiI6MTcyMDU3OTk0MCwicGF0aCI6Ii84NzEzMTgzMC8yNzg5NTA0NjctZTgyYjA1MDQtOGRhNC00NTE0LTgwMzgtM2Q2MjJiYjU1YTE1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzEwVDAyNTIyMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc0Zjc4OTg5Yjk5MWJlMzAyYjBhZGY0MGY0MzcyNzlkZjUyYzkwZTA1MzJhMmQxYzNjNDVmMWIyMzUyMzFhYzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.kwcLvR4F0r0wkdRIjbatLbL6-URrWAvTMlNhOxggXUQ)