Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MacOS ARM64 download links #24842

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

Charles-Gagnon
Copy link
Contributor

@Charles-Gagnon Charles-Gagnon commented Nov 1, 2023

Updates the download links when the emulated version of ADS is running on ARM64 MacOS

Original PR : #24841

For #24840

@Charles-Gagnon
Copy link
Contributor Author

@cheenamalhotra Do you have an ARM64 Mac you could use to verify this? I unfortunately do not 😄

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6721746763

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.006%) to 41.567%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/book/bookTreeView.ts 1 36.91%
extensions/notebook/src/dialog/configurePython/configurePathPage.ts 1 57.02%
src/sql/workbench/services/connection/browser/connectionDialogWidget.ts 1 73.44%
Totals Coverage Status
Change from base Build 6716094540: -0.006%
Covered Lines: 30783
Relevant Lines: 69356

💛 - Coveralls

@cheenamalhotra
Copy link
Member

@cheenamalhotra Do you have an ARM64 Mac you could use to verify this? I unfortunately do not 😄

These links redirect to download pages instead of specific OS/arch build - is that correct? However, why they're named to be `download-azure-data-studio-macos-arm64' - doesn't really add up.. do we want to keep using these forward links or fix them to redirect to package instead?

@Charles-Gagnon
Copy link
Contributor Author

Oh, yeah that's a good point. Updated!

@Charles-Gagnon
Copy link
Contributor Author

@cheenamalhotra Here's an adhoc build I kicked off to test with if you wanted to try that instead of pulling/rebuilding locally

https://mssqltools.visualstudio.com/CrossPlatBuildScripts/_build/results?buildId=215331&view=results

(or let me know if you're too busy and I'll find someone else)

@cheenamalhotra
Copy link
Member

Confirming URL is updated and redirects user to correct installable.

image

image

@Charles-Gagnon Charles-Gagnon merged commit 943a1ad into main Nov 1, 2023
21 checks passed
@Charles-Gagnon Charles-Gagnon deleted the chgagnon/updateArm64Links branch November 1, 2023 21:21
Charles-Gagnon added a commit that referenced this pull request Nov 1, 2023
Charles-Gagnon added a commit that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants