-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new backup database dialog to MSSQL extension #24910
Conversation
Pull Request Test Coverage Report for Build 6792116662Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
@@ -95,7 +102,9 @@ export abstract class ScriptableDialogBase<OptionsType extends ScriptableDialogO | |||
} | |||
let message: string; | |||
const script = await this.generateScript(); | |||
if (script) { | |||
if (this.opensEditorSeparately) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing backup & restore STS methods do their operations in the background, so we don't get a script back from the method call. This change is so we can return immediately without waiting on results.
This dialog uses the object management framework like our other admin dialogs, but re-uses the same STS calls as our existing backup experience. However, this dialog currently only supports backing up to a local file. I'll be adding URL support in subsequent PRs. We'll keep the current backup dialog around until the new dialog has the same feature parity and passes accessibility testing.
Closes #24588
Screenshots:
![NewBackupDialog](https://private-user-images.githubusercontent.com/12820011/281199321-9dff4977-2c05-4f74-ae14-7bdbcffdfde6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MjUxMDEsIm5iZiI6MTcxOTYyNDgwMSwicGF0aCI6Ii8xMjgyMDAxMS8yODExOTkzMjEtOWRmZjQ5NzctMmMwNS00Zjc0LWFlMTQtN2JkYmNmZmRmZGU2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDAxMzMyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI2NmFhMGYyZTIxMTlhM2VlZmQ4YzZmYmEwMDkyNDJlMDE4ZWE5YjJkNGU2ZTc4YmNhM2ZjYzA4YmNhMjM2NzImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.MX46gRCrFrw_rSUzxJfBxPVBhV8nxBDNs6zLty-rPPk)
With options expanded:
![NewBackupDialog2](https://private-user-images.githubusercontent.com/12820011/281199354-65de11f9-a3ca-4e7d-be55-744a7d47f155.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MjUxMDEsIm5iZiI6MTcxOTYyNDgwMSwicGF0aCI6Ii8xMjgyMDAxMS8yODExOTkzNTQtNjVkZTExZjktYTNjYS00ZTdkLWJlNTUtNzQ0YTdkNDdmMTU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDAxMzMyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgxZDI1ZDIzYjQ4YzUxNWVmOTU3NzZhOGRjNGM5ZjFmMWQ3YzE4MjlkOTYzODRhZWU4ZmYzMWEzNTdkNGFlODQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.t0ErxZs6gGV5MTJwbf024EF46aprSD9kZlKJ1aDjp6U)