Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new backup database dialog to MSSQL extension #24910

Merged
merged 95 commits into from
Nov 8, 2023
Merged

Conversation

corivera
Copy link
Member

@corivera corivera commented Nov 7, 2023

This dialog uses the object management framework like our other admin dialogs, but re-uses the same STS calls as our existing backup experience. However, this dialog currently only supports backing up to a local file. I'll be adding URL support in subsequent PRs. We'll keep the current backup dialog around until the new dialog has the same feature parity and passes accessibility testing.

Closes #24588

Screenshots:
NewBackupDialog

With options expanded:
NewBackupDialog2

@coveralls
Copy link

coveralls commented Nov 7, 2023

Pull Request Test Coverage Report for Build 6792116662

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.004%) to 41.577%

Files with Coverage Reduction New Missed Lines %
extensions/sql-database-projects/src/common/httpClient.ts 1 66.18%
extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts 2 52.03%
Totals Coverage Status
Change from base Build 6780078081: 0.004%
Covered Lines: 30789
Relevant Lines: 69355

💛 - Coveralls

@@ -95,7 +102,9 @@ export abstract class ScriptableDialogBase<OptionsType extends ScriptableDialogO
}
let message: string;
const script = await this.generateScript();
if (script) {
if (this.opensEditorSeparately) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing backup & restore STS methods do their operations in the background, so we don't get a script back from the method call. This change is so we can return immediately without waiting on results.

@corivera corivera merged commit a4b389e into main Nov 8, 2023
12 checks passed
@corivera corivera deleted the corivera/movebackup branch November 8, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Backup dialog to MSSQL extension
4 participants