Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove header metadata from update types script #24920

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

Charles-Gagnon
Copy link
Contributor

DefinitelyTyped changed their format, so the generated typings file doesn't need to have this metadata anymore.

@coveralls
Copy link

coveralls commented Nov 8, 2023

Pull Request Test Coverage Report for Build 6803208096

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 41.559%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/book/bookTreeView.ts 1 36.91%
extensions/sql-database-projects/src/common/httpClient.ts 1 66.18%
extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts 2 52.03%
extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts 7 41.73%
Totals Coverage Status
Change from base Build 6803069306: -0.02%
Covered Lines: 30777
Relevant Lines: 69355

💛 - Coveralls

@Charles-Gagnon Charles-Gagnon merged commit 36c3995 into main Nov 8, 2023
9 of 11 checks passed
@Charles-Gagnon Charles-Gagnon deleted the chgagnon/fixUpdateTypes branch November 8, 2023 20:39
siyao-Siyang pushed a commit that referenced this pull request Nov 13, 2023
* Remove header metadata from update types script

* compile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants