Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lingering issues with backup database dialog #24921

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Conversation

corivera
Copy link
Member

@corivera corivera commented Nov 9, 2023

Fixes these issues:

  1. Backup set name changing every time backup type is changed
  2. File list going blank when adding other rows
  3. File list allowing duplicate entries

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6805814720

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.574%

Totals Coverage Status
Change from base Build 6805648469: 0.0%
Covered Lines: 30787
Relevant Lines: 69355

💛 - Coveralls

@corivera corivera merged commit 2f3230c into main Nov 9, 2023
10 of 12 checks passed
@corivera corivera deleted the corivera/backupFixes branch November 9, 2023 20:17
siyao-Siyang pushed a commit that referenced this pull request Nov 13, 2023
* Fix backup set name changing every time backup type is changed

* Fix file list going blank when adding other rows

* Fix file list allowing duplicate entries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants