Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migration Experience][1.5.1] Update the refresh buttons. #24923

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

krritik
Copy link
Contributor

@krritik krritik commented Nov 9, 2023

Bug - https://dev.azure.com/msdata/Database%20Systems/_workitems/edit/2806472

Removed the dropdown for RefreshAssessment and RefreshSKU. Instead both are now as separate buttons in the toolbar -

  1. On PageEnter (disabled)
    image
  2. On Import Perf Data (disabled)
    image
  3. On start data collection (enabled)
    image

@coveralls
Copy link

coveralls commented Nov 9, 2023

Pull Request Test Coverage Report for Build 6863974226

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.005%) to 41.57%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/book/bookTreeView.ts 1 36.91%
extensions/sql-database-projects/src/common/httpClient.ts 1 66.18%
extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts 2 52.03%
Totals Coverage Status
Change from base Build 6860572786: -0.005%
Covered Lines: 30785
Relevant Lines: 69355

💛 - Coveralls

@krritik krritik merged commit 0557761 into main Nov 14, 2023
7 of 10 checks passed
@krritik krritik deleted the krritik/updateRefreshButtons branch November 14, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants