Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty values to determine xml cells #24933

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Handle empty values to determine xml cells #24933

merged 1 commit into from
Nov 10, 2023

Conversation

cheenamalhotra
Copy link
Member

Fixes #24929

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6817690939

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 41.569%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/sql/workbench/contrib/query/browser/gridPanel.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/sql/workbench/services/connection/browser/connectionDialogWidget.ts 1 73.44%
Totals Coverage Status
Change from base Build 6816980600: 0.003%
Covered Lines: 30785
Relevant Lines: 69355
💛 - Coveralls

@cheenamalhotra cheenamalhotra merged commit 86227d6 into main Nov 10, 2023
11 of 13 checks passed
@cheenamalhotra cheenamalhotra deleted the cheena/fix-xml branch November 10, 2023 00:38
cheenamalhotra added a commit that referenced this pull request Nov 10, 2023
@cheenamalhotra
Handle empty values to determine xml cells (#24933)
81e6a55
@cheenamalhotra cheenamalhotra mentioned this pull request Nov 10, 2023
Closed
siyao-Siyang pushed a commit that referenced this pull request Nov 13, 2023
@cheenamalhotra @siyangMicrosoft
Handle empty values to determine xml cells (#24933)
6563a39
cheenamalhotra added a commit that referenced this pull request Dec 12, 2023
@cheenamalhotra
Handle empty values to determine xml cells (#24933)
8a2fb6d
@cheenamalhotra cheenamalhotra mentioned this pull request Dec 12, 2023
Merged
cheenamalhotra added a commit that referenced this pull request Jan 2, 2024
@cheenamalhotra
Handle empty values to determine xml cells (#24933)
a865ad1
kisantia pushed a commit that referenced this pull request Jan 5, 2024
@cheenamalhotra
Handle empty values to determine xml cells (#24933) (#25114)
1fc3964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanrenmsft alanrenmsft alanrenmsft approved these changes

@kisantia kisantia kisantia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Query Results Unexpectedly Interpreted as XML When Blank String ('') Present
4 participants
@cheenamalhotra @coveralls @alanrenmsft @kisantia