Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require name when creating database #24953

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Require name when creating database #24953

merged 2 commits into from
Nov 14, 2023

Conversation

barbaravaldez
Copy link
Contributor

Fix #23823
image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6854306411

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 41.574%
Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePathPage.ts 1 57.02%
Totals Coverage Status
Change from base Build 6828665189: 0.004%
Covered Lines: 30787
Relevant Lines: 69355
💛 - Coveralls

@barbaravaldez barbaravaldez merged commit 58d7ed6 into main Nov 14, 2023
12 checks passed
@barbaravaldez barbaravaldez deleted the bavaldez/require branch November 14, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corivera corivera corivera approved these changes

@ssreerama ssreerama Awaiting requested review from ssreerama

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Name field should be marked as required in the New Database dialog
3 participants
@barbaravaldez @coveralls @corivera