Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add schema migration #24954

Merged
merged 2 commits into from
Nov 14, 2023
Merged

add schema migration #24954

merged 2 commits into from
Nov 14, 2023

Conversation

siyao-Siyang
Copy link
Contributor

1. Enable schema migration for SQL DB

First time to table selection page, schema migration shows 'Not selected'.
image

If schema migration is enabled, assessment results will be checked. If any assessment issues that might fail schema migration are found, it will show the assessment results link to check the details.
If schema migration is not enabled, there are two cases. If there are missing tables on the target but users don't select 'migrate schema to target' option, it will show 'Not selected'. If there are no missing tables on target, it will show 'Not needed'.

image

There are three tabs after click 'Edit':
The source tables exist on the target and have rows:
image
The source tables don't exist on the target and have rows:
image
The source tables dont have rows. These tables are not available to select for data migration. But if they dont exist on the target, schema migration is available.
image

2. Auto-mapping source database to target database.

Find if one of target database has the same name and collation to the selected source database, then this target database is set as dropdown component default value.
image

3. Integrate the assessment results with schema migration

User can click the 'Assessment results' link to check what issues might fail the schema migration
image
image

4. There are five scenarios:

4. 1. Full schema on target (Data only migration)
"Migrate schema to target" checkbox is disable.
image
image
image

4.2. Full schema missing on target
image
image

4.3. Partially schema missing on target
image

4.4. Failed migration
image

4.5. All source tables are empty.
If they don't exist on the target, the schema migration is still available but not available to select for data migration
image

5. Migration details list

Migration type: Schema only, Data only, Schema and data, Backup and restore
image

@coveralls
Copy link

coveralls commented Nov 13, 2023

Pull Request Test Coverage Report for Build 6867475153

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 41.576%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePathPage.ts 1 57.02%
Totals Coverage Status
Change from base Build 6828665189: 0.006%
Covered Lines: 30788
Relevant Lines: 69355

💛 - Coveralls

@siyao-Siyang siyao-Siyang merged commit 0871bf0 into main Nov 14, 2023
12 checks passed
@siyao-Siyang siyao-Siyang deleted the users/siyao/schema4 branch November 14, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants