Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mocha and azdata-test versions to update debug package dependency #24978

Merged
merged 3 commits into from
Nov 16, 2023

Conversation

kisantia
Copy link
Contributor

This updates the mocha and azdata-test package versions so that the minimum dependency on the debug package is no longer one that's flagged by the dependabot alerts (ex of one of the alerts: https://github.com/microsoft/azuredatastudio/security/dependabot/605).

This is the same version of mocha that the ADS package.json currently is:

"mocha": "^9.2.2",

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6886819235

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 41.568%

Files with Coverage Reduction New Missed Lines %
src/sql/workbench/services/connection/browser/connectionDialogWidget.ts 1 73.44%
Totals Coverage Status
Change from base Build 6882746685: -0.001%
Covered Lines: 30790
Relevant Lines: 69372

💛 - Coveralls

@kisantia
Copy link
Contributor Author

There were a few strange compilation errors in the integrations-tests and notebooks extensions that seemed related to the azdata-test package bump (example error: "This comparison appears to be unintentional because the types '3' and '0' have no overlap" for an assert in notebook.test.ts, which went away if I switched it to use assert.strictEqual), so the latest change undid the azdata-test bump in those two extensions and only the mocha version is getting updated for those two. I'll look into updating those two in a separate PR so it's easier to review, since this PR already has a lot of changes.

@cheenamalhotra
Copy link
Member

I'll look into updating those two in a separate PR so it's easier to review, since this PR already has a lot of changes.

Maybe worth opening a new issue, if it's low priority or you don't intend to do it right-away :)

@kisantia
Copy link
Contributor Author

I'll look into updating those two in a separate PR so it's easier to review, since this PR already has a lot of changes.

Maybe worth opening a new issue, if it's low priority or you don't intend to do it right-away :)

I'm planning to look into it later today, but good idea to open a tracking issue if I don't end up getting to it :)

@kisantia kisantia merged commit ab3a866 into main Nov 16, 2023
12 checks passed
@kisantia kisantia deleted the kisantia/updateDebugDependency branch November 16, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants