Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL Migration] [Bugfix] Not able to migrate few of the assessed DBs, it always selects all assessed. #25012

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

stuti149
Copy link
Contributor

Bug : Bug 2824863: We are not able to migrate few of the assessed DBs, it always selects all assessed.

Fix: Change1 : remove await this._body.treeComponent.initialize(this.migrationStateModel); from executechange method &
change const selectedDbs = this._dbNames.filter(db => this.model._databasesForAssessments.includes(db)); to
const selectedDbs = this._dbNames.filter(db => this.model._databasesForMigration.includes(db));

Change 2: Due to above change, when a tde enabled db is selected, tde info container was not showing up.
Fix: Update this.model._databasesForMigration = this.selectedDbs(); whenever any db is selected or unselected. This require pass of migrationstatemodel to treecomponent.

Change 3: Update select db count whenever a db is selected or unselected.
this._databaseCount.value = constants.DATABASES(selectedDbs.length, this.model._databasesForAssessment?.length)

Change2 & change3 are done to accomodate bugfix change

@coveralls
Copy link

Pull Request Test Coverage Report for Build 6945203592

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.569%

Totals Coverage Status
Change from base Build 6937690638: 0.0%
Covered Lines: 30791
Relevant Lines: 69372

💛 - Coveralls

@stuti149 stuti149 merged commit 306deae into main Nov 22, 2023
13 checks passed
@stuti149 stuti149 deleted the bugfix/stutijain/sqldb-target-selection branch November 22, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants