Sign out of GitHub Copilot #25014
Merged
Sign out of GitHub Copilot #25014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7147208485Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
kisantia
reviewed
Nov 21, 2023
src/sql/workbench/services/accountManagement/browser/accountListRenderer.ts
Show resolved
Hide resolved
kisantia
reviewed
Nov 21, 2023
src/sql/workbench/services/accountManagement/browser/accountDialog.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/services/accountManagement/browser/accountDialog.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/services/accountManagement/browser/accountDialog.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/services/accountManagement/browser/accountDialog.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/services/accountManagement/browser/accountDialog.ts
Outdated
Show resolved
Hide resolved
cheenamalhotra
requested changes
Nov 22, 2023
| @IAccountManagementService private _accountManagementService: IAccountManagementService, | ||
| @ILogService private _logService: ILogService, | ||
| @IAuthenticationService private readonly _authenticationService: IAuthenticationService | ||
| ) { | ||
| // Create our event emitters | ||
| this._addProviderEmitter = new Emitter<AccountProviderAddedEventParams>(); |
There was a problem hiding this comment.
These emitters are likely undisposed..
There was a problem hiding this comment.
Good catch, although I'd suggest going through and fixing those as a follow up PR to avoid cluttering up this PR even more
src/sql/workbench/services/accountManagement/browser/accountListRenderer.ts
Show resolved
Hide resolved
| const providerId = this._account.key.providerId; | ||
| const allSessions = await this.authenticationService.getSessions(providerId); | ||
| const sessionsForAccount = allSessions.filter(s => s.account.label === this._account.displayInfo.userId); | ||
| await this.authenticationService.removeAccountSessions(providerId, this._account.displayInfo.userId, sessionsForAccount); |
There was a problem hiding this comment.
Successfully signed out popup doesn't go away and requires user interaction, please make sure it goes away in 5-10 seconds.
| const providerId = this._account.key.providerId; | ||
| const allSessions = await this.authenticationService.getSessions(providerId); | ||
| const sessionsForAccount = allSessions.filter(s => s.account.label === this._account.displayInfo.userId); | ||
| await this.authenticationService.removeAccountSessions(providerId, this._account.displayInfo.userId, sessionsForAccount); |
There was a problem hiding this comment.
How does user sign in to Copilot again?
There was a problem hiding this comment.
maybe ADS should be restarted to complete the sign out process to make sure the copilot extension sign in notification is triggered?
lewis-sanchez
commented
Nov 26, 2023
| @IAccountManagementService private _accountManagementService: IAccountManagementService, | ||
| @ILogService private _logService: ILogService, | ||
| @IAuthenticationService private readonly _authenticationService: IAuthenticationService | ||
| ) { | ||
| // Create our event emitters | ||
| this._addProviderEmitter = new Emitter<AccountProviderAddedEventParams>(); |
There was a problem hiding this comment.
Good catch, although I'd suggest going through and fixing those as a follow up PR to avoid cluttering up this PR even more
src/sql/workbench/services/accountManagement/browser/accountManagementService.ts
Show resolved
Hide resolved
src/sql/workbench/services/accountManagement/browser/accountManagementService.ts
Show resolved
Hide resolved
src/vs/workbench/services/authentication/browser/authenticationService.ts
Outdated
Show resolved
Hide resolved
kisantia
approved these changes
Jan 5, 2024
siyao-Siyang
pushed a commit
that referenced
this pull request
Jan 11, 2024
* Sign out of GitHub Copilot * Code review changes * Remove unnecessary loop in action * Replace forEach call with map * Add hook to remove account after sign out * Revert "Add hook to remove account after sign out" This reverts commit 46b5f3c. * Revert "Revert "Add hook to remove account after sign out"" This reverts commit 5a401fa. * Comment out faulty code * Return empty array * Display provider name correctly * Add github logo for github accounts * Function argument rename * Remove account on sign out confirmation * Add missing semicolon * Code review changes * Implements mock auth service * Fix failing unit tests * Replaces callback hook with event handler * Remove updateAccountList hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #24478
The PR adds functionality to sign out of GitHub Copilot in Azure Data Studio.
The accounts section in ADS will show any active GitHub Copilot sessions that can be signed out of:
Clicking on the 'X' will then sign the user out and GitHub Copilot will then show a dialog informing the user to log in to the GitHub Copilot extension:
