-
Notifications
You must be signed in to change notification settings - Fork 882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix account refresh issue + enable extHostTreeView tests #25044
Conversation
Pull Request Test Coverage Report for Build 7013341802Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about a test as well? The VS Code people would probably like that too
I did attempt that, and noticed I had to expose new APIs or internal objects to test the same. We can reproduce the issue in tests, and see that cache doesn't contain the reference to child nodes, but to expose cache from public API seemed a little too much, so I didn't go for it. |
|
Fixes #24994
Noticed an issue with
extHostTreeViews
(vs), where refresh intends to clear children, but because child nodes are not registered in cached parent node, they don't clear and we face the issue above.For more details: PR microsoft/vscode#199061 addresses the same in VS Code.
Before:
![refresh-issue](https://private-user-images.githubusercontent.com/13396919/285550256-b0070fbe-8281-4b10-8dd7-49e1708d8461.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MjQ2MTgsIm5iZiI6MTcxOTYyNDMxOCwicGF0aCI6Ii8xMzM5NjkxOS8yODU1NTAyNTYtYjAwNzBmYmUtODI4MS00YjEwLThkZDctNDllMTcwOGQ4NDYxLmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDAxMjUxOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRlMzI1ZDYxZjJkYTliODZhM2ZlODIyOGI1MTI3MjU0MWY0MDY1MWJlZjcwMGMyYTY3ZjkwM2Q0M2NmNTg1ZWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.lcSrIephJP45NiPHlfKm2SjYsxRkK4nYPffy9xyuYHw)
After:
![refresh-fixed](https://private-user-images.githubusercontent.com/13396919/285550264-16fe1c05-c1ca-4d5a-bed8-e9dd4699edf5.gif?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2MjQ2MTgsIm5iZiI6MTcxOTYyNDMxOCwicGF0aCI6Ii8xMzM5NjkxOS8yODU1NTAyNjQtMTZmZTFjMDUtYzFjYS00ZDVhLWJlZDgtZTlkZDQ2OTllZGY1LmdpZj9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDAxMjUxOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI0ZTM4ZDgwOTI2ZDEyNzQwMTExOWNiN2Y4ZTQwMmVkNGQyMjE1ZTczMDk5YTljNmQ4NjRjYzUzOTNlNjQ1Y2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ZA06ncp2kCupTo5mYwm0m-2t-mCG8WYthWIAkodCU0k)