Fix Command line interface commands and connection management service to prompt for provider installation #25056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
requested review from
alanrenmsft,
Charles-Gagnon and
kisantia
Pull Request Test Coverage Report for Build 7039992431
💛 - Coveralls |
cheenamalhotra
force-pushed
the
cheena/fix-openConnectionDialog
branch
from
5a97a6b
to
e38e831
Compare
cheenamalhotra
commented
Nov 28, 2023
src/sql/workbench/contrib/commandLine/electron-sandbox/commandLine.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/contrib/commandLine/electron-sandbox/commandLine.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/services/connection/browser/connectionDialogService.ts
Show resolved
Hide resolved
cheenamalhotra
force-pushed
the
cheena/fix-openConnectionDialog
branch
from
b17a1d1
to
0986b8f
Compare
src/sql/workbench/contrib/commandLine/electron-sandbox/commandLine.ts
Outdated
Show resolved
Hide resolved
src/sql/workbench/contrib/commandLine/test/electron-browser/commandLine.test.ts
Outdated
Show resolved
Hide resolved
Charles-Gagnon
approved these changes
Nov 29, 2023
cheenamalhotra
force-pushed
the
cheena/fix-openConnectionDialog
branch
from
a28df23
to
15b094f
Compare
New Notebook action is fine, but other commands are currently not able to consume connection profile passed by user, due to #25068 - let me know your thoughts on it. I was thinking to deprecate the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25050 and fixes #25055
Tested both commands from CLI args when working with unknown/known providers:
Note: Prompt added in Connection Management Service asks users to install extension again when user tries to connect despite canceling the first installation prompt.