Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add restore from url for SQL Server #25062

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Add restore from url for SQL Server #25062

merged 8 commits into from
Dec 6, 2023

Conversation

barbaravaldez
Copy link
Contributor

image

image

@corivera
Copy link
Member

Are there any fields that need to be disabled or updated when toggling between File and URL modes? Like any of the fields that deal with local file paths. For example: Standby File or Tail Log Backup File

@coveralls
Copy link

coveralls commented Nov 28, 2023

Pull Request Test Coverage Report for Build 7105778782

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 40 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.04%) to 41.604%

Files with Coverage Reduction New Missed Lines %
extensions/notebook/src/dialog/configurePython/configurePathPage.ts 1 57.02%
src/sql/workbench/services/connection/browser/connectionDialogService.ts 11 79.2%
extensions/azurecore/src/azureResource/tree/treeProvider.ts 14 60.61%
src/sql/workbench/contrib/commandLine/electron-sandbox/commandLine.ts 14 82.99%
Totals Coverage Status
Change from base Build 7022797788: 0.04%
Covered Lines: 30818
Relevant Lines: 69389

💛 - Coveralls

@barbaravaldez
Copy link
Contributor Author

barbaravaldez commented Nov 29, 2023

Are there any fields that need to be disabled or updated when toggling between File and URL modes? Like any of the fields that deal with local file paths. For example: Standby File or Tail Log Backup File

Yup, you are right! The correct fields are enabled (I compared them to SSMS). I just need to update the Tail Log Backup file path.

Copy link
Member

@corivera corivera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me apart from the offline comments about tail log backup being a URL path.

@barbaravaldez barbaravaldez merged commit 135b5e3 into main Dec 6, 2023
12 checks passed
@barbaravaldez barbaravaldez deleted the bavaldez/restore branch December 6, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants