Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restore dialog not showing a message after clicking Script #25065

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

corivera
Copy link
Member

When clicking script in the Restore Database dialog, it kept showing a message saying there was no action to be scripted even though a script window was being opened in the background. The dialog needed to have its opensEditorSeparately flag set to true, since the Restore scripting operation opens an editor separately from the usual object management workflow.

Also fixed some unlocalized strings in the backup dialog while I was at it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7025920762

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 41.566%

Totals Coverage Status
Change from base Build 7024675834: 0.001%
Covered Lines: 30791
Relevant Lines: 69376

💛 - Coveralls

Copy link
Contributor

@ssreerama ssreerama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch!

@corivera corivera merged commit dbd7eb7 into main Nov 29, 2023
13 checks passed
@corivera corivera deleted the corivera/restoreScripting branch November 29, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants