Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Catppuccin theme extension #25077

Merged
merged 1 commit into from
Nov 30, 2023
Merged

add Catppuccin theme extension #25077

merged 1 commit into from
Nov 30, 2023

Conversation

nekowinston
Copy link

Adds Catppuccin for Azure Data Studio to both extensionsGallery and extensionsGallery-insider.
It's pulling from our VSCode theme, but the VSIX is a special build for ADS.

Copy link

MSFT Gallery Maintainer Only
This is a reminder to update the Extensions Gallery list at https://github.com/Microsoft/azuredatastudio/wiki/List-of-Extensions once this PR has been merged in.
Instructions for doing this can be found here.

@nekowinston
Copy link
Author

@microsoft-github-policy-service agree

@Charles-Gagnon
Copy link
Contributor

Hey @nekowinston, thanks for your contribution! We'd love to get this added, but unfortunately at this time we don't allow direct VSIX installs from external sources. So you'll need to replace the Microsoft.VisualStudio.Services.VSIXPackage value with Microsoft.SQLOps.DownloadPage

e.g. https://github.com/microsoft/azuredatastudio/blob/release/extensions/extensionsGallery.json#L206

You will also need to update the count at the bottom of the file (increase it by 1) : https://github.com/microsoft/azuredatastudio/blob/release/extensions/extensionsGallery.json#L5281

@Charles-Gagnon Charles-Gagnon self-assigned this Nov 30, 2023
@Charles-Gagnon Charles-Gagnon merged commit 9dd7d17 into microsoft:release/extensions Nov 30, 2023
3 checks passed
@nekowinston
Copy link
Author

Thanks! 😄

@nekowinston nekowinston deleted the release/extensions branch November 30, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants