-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Restore URL support to the new OM restore dialog for MI Server #25080
Conversation
Pull Request Test Coverage Report for Build 7123315438
💛 - Coveralls |
extensions/mssql/src/objectManagement/ui/restoreDatabaseDialog.ts
Outdated
Show resolved
Hide resolved
extensions/mssql/src/objectManagement/ui/restoreDatabaseDialog.ts
Outdated
Show resolved
Hide resolved
Tried the changes out locally since they were a bit complicated to parse through just in text. I'm hitting an issue where the dialog is stuck in a spinning state after selecting a backup file from blob storage to use for the Restore from URL scenario. I'm using both of your ADS and STS branches for this change. Looks like some For my test scenario, I made a backup from a 2022 Docker instance, and then tried to select that backup file from a storage account when restoring to a newly created Managed Instance database. The backup file might end up being incompatible due to version differences, but I'm not even able to get to the step where I can Script out the operation or hit Restore. The buttons remain grayed out. |
Hey @corivera , I tried to repro the issue and couldn't, it is working fine. Below are the steps that I followed.
Please correct me if I missed any step. Thanks |
Able to found couple of issues with Docker and fixed them also, added URL support to on-prem servers. (MI supports only URL, all other supports database/back-up files/ URL) |
Adds the ability to support the restore database from URL, for a new restore dialog and for MI databases.
Note: TODO: Tasks tab shows multiple messages (unwanted one even in fail cases) will send a new PR if it takes time.