Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL Migration] Fix schema migration table selection issue #25136

Merged
merged 4 commits into from
Dec 16, 2023

Conversation

siyao-Siyang
Copy link
Contributor

@siyao-Siyang siyao-Siyang commented Dec 15, 2023

Issue:
If tables in "Missing on target" tab are selected, schema migration option won't be checked automatically. It causes that the selected tables dont exist in target and fail the SqlInfoCollector validation.

Fix:
if users don't select schema migration option and just select the tables in "missing on target" tab, enable schema migration automatically.

image

@coveralls
Copy link

coveralls commented Dec 15, 2023

Pull Request Test Coverage Report for Build 7228187689

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 41.603%

Files with Coverage Reduction New Missed Lines %
src/sql/workbench/services/connection/browser/connectionDialogWidget.ts 1 73.44%
Totals Coverage Status
Change from base Build 7191361300: -0.001%
Covered Lines: 30817
Relevant Lines: 69389

💛 - Coveralls

@siyao-Siyang siyao-Siyang merged commit 93cc254 into main Dec 16, 2023
12 checks passed
@siyao-Siyang siyao-Siyang deleted the users/siyao/irversioncheck branch December 16, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants